Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search] DRY helper for encoding/decoding routes that can have special characters in params #89811

Merged
merged 10 commits into from
Feb 2, 2021
Merged

[App Search] DRY helper for encoding/decoding routes that can have special characters in params #89811

merged 10 commits into from
Feb 2, 2021

Commits on Jan 30, 2021

  1. Add encodePathParam helper + update components that need it 

    - Primarily document URLs & analytics queries (which uses generateEnginePath)
    @cee-chen
    cee-chen committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    8a644db View commit details
    Browse the repository at this point in the history

  2. Add useDecodedParams helper + update components that need it 

    - Documents titles & Analytics queries
    @cee-chen
    cee-chen committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    5a2d9a6 View commit details
    Browse the repository at this point in the history

  3. [Misc] Change popout icon to eye 

    - Feedback from Davey - the pages don't open in a new window, so shouldn't use the popout icon
- Not strictly related but since we're touching these links anyway, I'm shoving it in (sorry)
    @cee-chen
    cee-chen committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    c0ad74e View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Remove document detail decode test 

    - now handled/tested by useDecodedParams helper
    @cee-chen
    cee-chen committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    12e4db9 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Add new generateEncodedPath helper 

    - Should be used in place of generatePath
    @cee-chen
    cee-chen committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    68a3057 View commit details
    Browse the repository at this point in the history

  2. Update all instances of generatePath to generateEncodedPath 

    for consistency across the App Search codebase
    @cee-chen
    cee-chen committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    a72aef2 View commit details
    Browse the repository at this point in the history

  3. Fix failing tests due to extra encodeURI() done by generatePath

    @cee-chen
    cee-chen committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    9dd3fdf View commit details
    Browse the repository at this point in the history

  4. Add missing branch test for analytics query titles

    @cee-chen
    cee-chen committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    b4b4b6a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into encode-decode-helper

    @kibanamachine
    kibanamachine authored Feb 2, 2021
    Configuration menu
    Copy the full SHA
    a64d53a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into encode-decode-helper

    @kibanamachine
    kibanamachine authored Feb 2, 2021
    Configuration menu
    Copy the full SHA
    8f3568f View commit details
    Browse the repository at this point in the history