Commits on Feb 2, 2021

1. [App Search] DRY helper for encoding/decoding routes that can have sp… …

   …ecial characters in params (elastic#89811)
   
   * Add encodePathParam helper + update components that need it
   
   - Primarily document URLs & analytics queries (which uses generateEnginePath)
   
   * Add useDecodedParams helper + update components that need it
   
   - Documents titles & Analytics queries
   
   * [Misc] Change popout icon to eye
   
   - Feedback from Davey - the pages don't open in a new window, so shouldn't use the popout icon
   - Not strictly related but since we're touching these links anyway, I'm shoving it in (sorry)
   
   * Remove document detail decode test
   
   - now handled/tested by useDecodedParams helper
   
   * Add new generateEncodedPath helper
   
   - Should be used in place of generatePath
   
   * Update all instances of generatePath to generateEncodedPath
   
   for consistency across the App Search codebase
   
   * Fix failing tests due to extra encodeURI() done by generatePath
   
   * Add missing branch test for analytics query titles
   
   Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

   

   2 people authored and cee-chen committed Feb 2, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for a20f1e9
   • Browse repository at this point

   Copy the full SHA

   a20f1e9 View commit details

   Browse the repository at this point in the history