-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Visualize Link Redirecting to Dashboard Linked Visualization #90243
Fix Visualize Link Redirecting to Dashboard Linked Visualization #90243
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested that this only affects the flow you're talking about, but does not affect the flow if you started from Visualize. LGTM
!urlToSave.includes(`${VisualizeConstants.EDIT_PATH}/`) && | ||
this.isLinkedToOriginatingApp?.() | ||
) { | ||
return core.http.basePath.prepend('/app/visualize'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this isn't pulled out into a separate constant of some kind, in case it ever changes or becomes configurable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was surprised about this too - though it was only used once before this PR so maybe this is the right time to pull it out. Will add it to the constants.
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
FIxes #90221 (option 2) by using
onBeforeNavLinkSaved
to return the nav link only when the state transfer service is not linked to an originating app. Otherwise it will return the visualize listing page.Checklist
Delete any items that are not applicable to this PR.
For maintainers