Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] convert HeatmapLayer to TS #90666

Merged
merged 6 commits into from
Feb 9, 2021
Merged

[Maps] convert HeatmapLayer to TS #90666

merged 6 commits into from
Feb 9, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 8, 2021

Converts HeatmapLayer to TS. HeatmapLayer not longer extends VectorLayer

@nreese nreese added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Feb 9, 2021

@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

x-pack/plugins/maps/public/classes/layers/vector_layer/utils.tsx
@@ -0,0 +1,114 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thx for extracting

@nreese
Copy link
Contributor Author

nreese commented Feb 9, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Feb 9, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 689 692 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +997.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit a9ee83c into elastic:master Feb 9, 2021
nreese added a commit to nreese/kibana that referenced this pull request Feb 9, 2021
@nreese @kibanamachine
[Maps] convert HeatmapLayer to TS (elastic#90666)
1a98cc8 
* [Maps] convert HeatmapLayer to TS

* make VectorLayer implement IVectorLayer

* fix jest test and functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@nreese nreese mentioned this pull request Feb 9, 2021
Merged
nreese added a commit that referenced this pull request Feb 10, 2021
@nreese @kibanamachine
[Maps] convert HeatmapLayer to TS (#90666) (#90871)
3e3a33e 
* [Maps] convert HeatmapLayer to TS

* make VectorLayer implement IVectorLayer

* fix jest test and functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Feb 23, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck