Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Use newfeed.service config for all newsfeeds (#90252) #90681

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

gtback
Copy link
Member

@gtback gtback commented Feb 8, 2021

Backports the following commits to 7.x:

Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@gtback gtback added the backport label Feb 8, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
newsfeed 20.6KB 20.7KB +23.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gtback gtback requested a review from afharo February 8, 2021 22:53
@gtback
Copy link
Member Author

gtback commented Feb 8, 2021

@afharo sorry for all the questions, but this process is new to me. Should I get a 👍🏻 on this before merging, or is it safe to merge right now because the previous PR was approved?

@afharo
Copy link
Member

afharo commented Feb 9, 2021

You can merge backports without previous approvals 👍

Just run a sanity check yourself to make sure you are not including more changes than expected (usually happens when some other previous backport has not been completed yet). This is not the case here. You can merge straight away 😉

@gtback gtback merged commit 83ea30d into elastic:7.x Feb 9, 2021
@gtback gtback deleted the backport/7.x/pr-90252 branch February 9, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants