Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email connector info for Elastic Cloud #91363

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

nrichers
Copy link
Contributor

@nrichers nrichers commented Feb 15, 2021

Summary

doc preview

This PR adds a section for email connectors that use Elastic Cloud:

image

The steps are based on @trengrj's https://github.com/elastic/cloud/issues/71090#issuecomment-738383463. Note that I was not able to test these steps successfully, as I kept getting the following error:

image

Closes https://github.com/elastic/cloud/issues/72456 (once that error is sorted out)

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@nrichers nrichers requested a review from a team as a code owner February 15, 2021 05:59
@nrichers nrichers added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 v7.13.0 v7.14.0 labels Feb 15, 2021
@trengrj
Copy link
Contributor

trengrj commented Feb 15, 2021

@nrichers I've tested in 7.11.0 and get the same error. However when creating a newly created Elastic Cloud 7.10.2 cluster the Test email functionality works fine. More information is needed to determine if this is related to Kibana or Elastic Cloud.

@nrichers
Copy link
Contributor Author

More information is needed to determine if this is related to Kibana or Elastic Cloud.

@trengrj do you want me to follow up or will you? It sounds like we might need a GH issue in either the Cloud or the Kibana repo to get this started.

@nrichers
Copy link
Contributor Author

Chatted with @trengrj and this will need more than a docs change to address, see https://github.com/elastic/cloud/issues/71090#issuecomment-780192553. Closing this PR as we can't merge it as is.

@nrichers nrichers closed this Feb 16, 2021
@pmuellr
Copy link
Member

pmuellr commented Feb 19, 2021

There's not enough information here re: the cloud email proxy, as there is additional setup required - or at least used to be required. Specifically, I believe the email addresses being sent TO need to be whitelisted. I can't find a link in cloud for where to do this, it might be in an email that the mail proxy sends when you send to an address which isn't whitelisted. And that email is likely to land in a spam bucket - it did for me.

Will need some additional text to explain this, or we'll get lots of issues reported about it not working.

@Leaf-Lin
Copy link
Contributor

@pmuellr
Copy link
Member

pmuellr commented Mar 1, 2021

Ah cool, I didn't realize we had this documented!

So I think we can add a link in the email section to that cloud doc - or we could copy it, but that doesn't seem right - I'd be happy adding this.

I'm wondering if any other "from" (ie "sender") addresses would work besides noreply@watcheralert.found.io. Eg, noreply@kibana-alert.found.io- a url with elastic in it would be even better!

@pmuellr pmuellr reopened this Mar 1, 2021
@pmuellr
Copy link
Member

pmuellr commented Mar 1, 2021

This is currently blocked by PR #91760 - which means it won't be available until some 7.12 point release &| 7.13 - I'm assuming we'd want this out ASAP, so in a 7.12 point release?

@pmuellr
Copy link
Member

pmuellr commented Mar 15, 2021

The fix that was blocking adding this has shipped in 7.11.2 - PR #91760 - so we should be able to test it again.

In terms of the PR, we made a lot of changes to the alerting docs over the last month, so there may be a conflict after merging master.

Also, the doc in the PR should include a link to the "whitelist" processing in cloud - https://www.elastic.co/guide/en/cloud/current/ec-watcher.html#ec-watcher-whitelist

@pmuellr
Copy link
Member

pmuellr commented May 4, 2021

Did someone want to refresh this PR? It appears the formatting may have changed, as the way the parameters are specified is different than all the other example mail providers.

It also needs a link to, or copy of, the text explaining how to allow-list email addresses when using this service.

@Leaf-Lin
Copy link
Contributor

Hi, I have tested this on 7.13.2, and I can confirm the information is correct. FWIW, here's a screenshot, and it works with the following setting. @nrichers , @pmuellr , could you please finish finalising this PR? Thanks!
Screen Shot 2021-06-16 at 7 59 48 pm

Copy link
Contributor

@Leaf-Lin Leaf-Lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nrichers
Copy link
Contributor Author

Thank you for testing and approving, @Leaf-Lin! I'm surprised this old PR is actually still kicking around, I'd written it off long ago. 🙂

@pmuellr looks like there is a merge conflict, will fix. Can you tell me if the rest of the PR looks good to merge, esp. the labels? I don't contribute to this repo often, so would appreciate your guidance.

@nrichers nrichers force-pushed the add-cloud-connector-settings branch from 67b2fa8 to f6e000a Compare June 18, 2021 17:49
@nrichers
Copy link
Contributor Author

Looks like the source file for this content is different now, reworked the PR to match. Should be good to merge after the checks pass.

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per comment #91363 (comment) , we need to add a link to info describing how the whitelisting works with the cloud mail server. I think the best link is here, provided by Leaf:

https://www.elastic.co/guide/en/cloud/current/ec-watcher.html#ec-watcher-whitelist

Other than that, LGTM! Thanks!

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding the white listing reference!

@nrichers nrichers merged commit db312e5 into elastic:master Jun 18, 2021
nrichers pushed a commit to nrichers/kibana that referenced this pull request Jun 18, 2021
* Move content into new location to fix merge conflict

* Add whitelisting callout
nrichers pushed a commit that referenced this pull request Jun 18, 2021
* Move content into new location to fix merge conflict

* Add whitelisting callout
nrichers pushed a commit that referenced this pull request Jun 18, 2021
* Move content into new location to fix merge conflict

* Add whitelisting callout
@nrichers
Copy link
Contributor Author

Final update: I backported to 7.x and 7.14 to make sure this change goes live in our current docs and updated the labels for this PR to match.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 21, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (447 commits)
  skip flaky suite (elastic#102366)
  [Security Solution][Endpoint][Host Isolation] Isolation status badge from alert details (elastic#102274)
  Add email connector info for Elastic Cloud (elastic#91363)
  [Workplace Search] remove or replace xs props for text on source connect view (elastic#102663)
  Do not double register dashboard url generator (elastic#102599)
  [TSVB] Replaces EuiCodeEditor 👉 Monaco editor  (elastic#100684)
  [Discover] Update kibana.json adding owner and description (elastic#102292)
  [Exploratory View] Mobile experience (elastic#99565)
  chore(NA): moving @kbn/ui-shared-deps into bazel (elastic#101669)
  [TSVB] Index pattern select field disappear in Annotation tab (elastic#102314)
  [Security Solution][Endpoint][Host Isolation] Fixes bug where host isolation/unisolation works from alert details (elastic#102581)
  TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 (elastic#102494)
  [Logs UI] Add `event.original` fallback to message reconstruction rules (elastic#102236)
  [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506)
  [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384)
  [ML] Anomaly detection job custom_settings improvements (elastic#102099)
  [Cases] Route: Get all alerts attach to a case (elastic#101878)
  Fixes wrong list exception type when creating endpoint event filters list (elastic#102522)
  remove search bar that's not working yet (elastic#102550)
  Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants