Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vislib] Use timestamp on brush event instead of iso dates #91483

Merged
merged 4 commits into from
Feb 17, 2021
Merged

[Vislib] Use timestamp on brush event instead of iso dates #91483

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
208c416
[Vislib] Use timestamp on brush event instead of iso dates
stratoula Feb 16, 2021
6630313
Merge branch 'master' into vislib-brush-timestamp
kibanamachine Feb 17, 2021
bad1279
Fix functional test and update documentation
stratoula Feb 17, 2021
5e8eac8
Update documentation
stratoula Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/plugins/vis_type_vislib/public/vislib/lib/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import d3 from 'd3';
import _ from 'lodash';
import MarkdownIt from 'markdown-it';
import moment from 'moment';

import { dispatchRenderComplete } from '../../../../kibana_utils/public';

Expand All @@ -26,6 +27,10 @@ const markdownIt = new MarkdownIt({
linkify: true,
});

const convertToTimestamp = (dateString) => {
return parseInt(moment(dateString).format('x'));
stratoula marked this conversation as resolved.
Show resolved Hide resolved
};

/**
* Handles building all the components of the visualization
*
Expand Down Expand Up @@ -80,11 +85,13 @@ export class Handler {
case 'brush':
const xRaw = _.get(eventPayload.data, 'series[0].values[0].xRaw');
if (!xRaw) return; // not sure if this is possible?
const [start, end] = eventPayload.range;
const range = [convertToTimestamp(start), convertToTimestamp(end)];
return self.vis.emit(eventType, {
name: 'brush',
data: {
table: xRaw.table,
range: eventPayload.range,
range,
column: xRaw.column,
},
});
Expand Down