[Discover] Always request unmapped fields in a single doc view and a context view #91825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
added
v7.12.0
release_note:skip
kertal
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
approved these changes
Feb 18, 2021
majagrubic
changed the title
flash1293
approved these changes
Feb 18, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
31 tasks
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Feb 18, 2021
…context view (elastic#91825) * [Discover] Always request unmapped fields in a single doc view * Updating unit test * Request unmapped fields in context view
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Feb 18, 2021
…context view (elastic#91825) * [Discover] Always request unmapped fields in a single doc view * Updating unit test * Request unmapped fields in context view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially fixes: #91688
As a quick fix, we'll always request unmapped fields if using the fields API in the single document view and a single doc view.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/c29adfef29e921cc447d2a5ed06ac2047ceab552/src/dev/build/tasks/os_packages/docker_generator/resources/bin/kibana-docker)- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)- [ ] This was checked for cross-browser compatibilityFor maintainers