[Security Solution][Case] Fix subcases bugs on detections and case view #91836

cnasikas · 2021-02-18T13:21:52Z

Summary

Fixes a list of bugs on detections and case view:

Meta: #91843

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-02-18T13:21:54Z

Pinging @elastic/kibana-security (Team:Security)

elasticmachine · 2021-02-18T13:21:54Z

Pinging @elastic/security-detections-response (Team:Detections and Resp)

elasticmachine · 2021-02-18T13:27:48Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2021-02-18T15:11:44Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

…ix_subcases_bugs

jonathan-buttner

Backend changes look good, I left a couple comments on the front end changes.

x-pack/plugins/security_solution/public/cases/components/create/form_context.tsx

...ck/plugins/security_solution/public/cases/components/timeline_actions/add_to_case_action.tsx

…ix_subcases_bugs

jonathan-buttner

Nice work here!

I tested a couple things:

Manually adding alerts to case

Collections are disabled ✅
Sub cases are clickable ✅

One UX improvement here I think would be to use a different color for the disabled rows in the table. Currently it looks like the collections are already selected. I'm not sure how much work that'd be to change though.

Navigating to a collection

No longer shows the status ✅

Adding/editing a comment on a sub case ✅

User actions are shown for sub case ✅

Manually attaching an alert for a sub case ✅

I'm not sure if this was something we were trying to address in this PR but an empty collection has it's status displayed and is selectable for bulk actions. I think that might be an existing issue though. I added it to the meta ticket here: #91843

jonathan-buttner · 2021-02-26T03:01:53Z

x-pack/plugins/security_solution/public/cases/components/case_view/index.tsx

-                          onStatusChanged={changeStatus}
-                          disabled={!userCanCrud}
-                          isLoading={isLoading && updateKey === 'status'}
+                    {(caseData.type !== CaseType.collection || hasDataToPush) && (


I was trying to find a better way to do this instead of having the double checks but couldn't think of one haha 👍

Me too. I fought a lot with this :)

jonathan-buttner · 2021-02-26T03:04:45Z

x-pack/plugins/security_solution/public/cases/components/use_create_case_modal/index.tsx

@@ -29,7 +29,7 @@ export const useCreateCaseModal = ({
  const closeModal = useCallback(() => setIsModalOpen(false), []);
  const openModal = useCallback(() => setIsModalOpen(true), []);
  const onSuccess = useCallback(
-    (theCase) => {
+    async (theCase) => {


Do we need the async here? Do we need an await on one of the calls?

form_context.tsx expects onSuccess: (theCase: Case) => Promise<void> and waits for the onSuccess to be fulfilled. Do you think it shouldn't?

cnasikas · 2021-02-26T07:59:34Z

@jonathan-buttner Thank you so much for testing!!

One UX improvement here I think would be to use a different color for the disabled rows in the table. Currently it looks like the collections are already selected. I'm not sure how much work that'd be to change though.

You are right. I think we should discuss it with @monina-n and address it on another PR.

I'm not sure if this was something we were trying to address in this PR but an empty collection has it's status displayed and is selectable for bulk actions. I think that might be an existing issue though. I added it to the meta ticket here: #91843

Yes, it wasn't supposed to be addressed in this PR. Maybe this #91863 gonna address it.

kibanamachine · 2021-02-26T13:04:19Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2204	2202	-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.8MB	7.8MB	+1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	235.9KB	235.8KB	-127.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

…ew (elastic#91836) Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co> # Conflicts: # x-pack/plugins/security_solution/public/cases/components/status/config.ts

…ew (#91836) (#92966) Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co> Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>

…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (40 commits) [Security Solution][Case][Bug] Improve case logging (elastic#91924) [Alerts][Doc] Added README documentation for alerts plugin status and framework health checks configuration options. (elastic#92761) Add warning for EQL and Threshold rules if exception list contains value list items (elastic#92914) [Security Solution][Case] Fix subcases bugs on detections and case view (elastic#91836) [APM] Always allow access to Profiling via URL (elastic#92889) [Vega] Allow image loading without CORS policy by changing the default to crossOrigin=null (elastic#91991) skip flaky suite (elastic#92114) [APM] Fix for default fields in correlations view (elastic#91868) (elastic#92090) chore(NA): bump bazelisk to v1.7.5 (elastic#92905) [Maps] fix selecting EMS basemap does not populate input (elastic#92711) API docs (elastic#92827) [kbn/test] add import/export support to KbnClient (elastic#92526) Test fix management scripted field filter functional test and unskip it (elastic#92756) [App Search] Create Curation view/functionality (elastic#92560) [Reporting/Discover] include the document's entire set of fields (elastic#92730) [Fleet] Add new index to fleet for artifacts being served out of fleet-server (elastic#92860) [Alerts][Doc] Added README documentation for API key invalidation configuration options. (elastic#92757) [Discover][docs] Add search for relevance (elastic#90611) [Alerts][Docs] Extended README.md and the user docs with the licensing information. (elastic#92564) [7.12][Telemetry] Security telemetry allowlist fix. (elastic#92850) ...

…ew (elastic#91836) Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co> # Conflicts: # x-pack/plugins/security_solution/public/cases/components/status/config.ts

…ew (#91836) (#92967) Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co> # Conflicts: # x-pack/plugins/security_solution/public/cases/components/status/config.ts

cnasikas added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 Team:Detections and Resp Security Detection Response Team labels Feb 18, 2021

cnasikas self-assigned this Feb 18, 2021

cnasikas requested a review from a team as a code owner February 18, 2021 13:21

azasypkin added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. and removed Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Feb 18, 2021

cnasikas changed the title ~~[Security Solution][Case] Fix subcases bugs~~ [Security Solution][Case] Fix subcases bugs on detections Feb 18, 2021

cnasikas added Team:Threat Hunting Security Solution Threat Hunting Team and removed Team:Detections and Resp Security Detection Response Team labels Feb 18, 2021

cnasikas requested a review from a team February 18, 2021 15:11

cnasikas changed the title ~~[Security Solution][Case] Fix subcases bugs on detections~~ [Security Solution][Case] Fix subcases bugs on detections and case view Feb 18, 2021

cnasikas added the bug Fixes for quality problems that affect the customer experience label Feb 18, 2021

cnasikas mentioned this pull request Feb 22, 2021

[Security Solution][Case] Subcases bugs #91843

Closed

30 tasks

cnasikas added 4 commits February 22, 2021 13:11

Fix bug with case connector UI

538f2d9

Disable closed cases on detections

3e6fadd

Fix bug with alert query

8dd955e

Fix order of attaching alert to a case

348772a

cnasikas force-pushed the fix_subcases_bugs branch from b73f02f to 348772a Compare February 22, 2021 15:00

cnasikas added 3 commits February 22, 2021 19:09

Fix icon

3936948

Select only subcases on modal

e90abd9

Better error messages

41fd862

cnasikas force-pushed the fix_subcases_bugs branch from 13b811b to 41fd862 Compare February 23, 2021 16:19

Remove CollectionWithSubCaseResponse

9738128

jonathan-buttner added 2 commits February 24, 2021 11:09

Fixing sub case comment integration tests

8146664

Merge branch 'fix_subcases_bugs' of github.com:cnasikas/kibana into f…

b17470b

…ix_subcases_bugs

jonathan-buttner reviewed Feb 24, 2021

View reviewed changes

x-pack/plugins/security_solution/public/cases/components/create/form_context.tsx Show resolved Hide resolved

...ck/plugins/security_solution/public/cases/components/timeline_actions/add_to_case_action.tsx Show resolved Hide resolved

cnasikas added the v7.13.0 label Feb 24, 2021

cnasikas and others added 7 commits February 24, 2021 21:52

Merge branch 'master' into fix_subcases_bugs

ceea3f4

Fixing patch sub cases integration tests

5449edf

Hide status from collections

7d8a09f

Merge branch 'fix_subcases_bugs' of github.com:cnasikas/kibana into f…

735ae92

…ix_subcases_bugs

Fix types

3622df1

Merge branch 'master' into fix_subcases_bugs

f0c4886

Fixes

6131afa

cnasikas force-pushed the fix_subcases_bugs branch from e6c44b9 to 6131afa Compare February 25, 2021 18:17

jonathan-buttner approved these changes Feb 26, 2021

View reviewed changes

Fix comment id

cea5dbb

cnasikas added 4 commits February 26, 2021 10:01

Merge branch 'master' into fix_subcases_bugs

8f8a7b5

Fix tests

361336f

Show toaster when attaching to an existing case

50d851d

Fix tests

936df23

cnasikas merged commit c2877a6 into elastic:master Feb 26, 2021

cnasikas deleted the fix_subcases_bugs branch February 26, 2021 13:35

This was referenced Feb 26, 2021

[7.x] [Security Solution][Case] Fix subcases bugs on detections and case view (#91836) #92966

Merged

[7.12] [Security Solution][Case] Fix subcases bugs on detections and case view (#91836) #92967

Merged

cnasikas mentioned this pull request Mar 2, 2021

[Security Solution][Case] Fix individual case deletion on case view #93218

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Case] Fix subcases bugs on detections and case view #91836

[Security Solution][Case] Fix subcases bugs on detections and case view #91836

cnasikas commented Feb 18, 2021 •

edited

Loading

elasticmachine commented Feb 18, 2021

elasticmachine commented Feb 18, 2021

elasticmachine commented Feb 18, 2021

elasticmachine commented Feb 18, 2021

jonathan-buttner left a comment

jonathan-buttner left a comment •

edited

Loading

jonathan-buttner Feb 26, 2021

cnasikas Feb 26, 2021 •

edited

Loading

jonathan-buttner Feb 26, 2021

cnasikas Feb 26, 2021

cnasikas commented Feb 26, 2021 •

edited

Loading

kibanamachine commented Feb 26, 2021

[Security Solution][Case] Fix subcases bugs on detections and case view #91836

[Security Solution][Case] Fix subcases bugs on detections and case view #91836

Conversation

cnasikas commented Feb 18, 2021 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Feb 18, 2021

elasticmachine commented Feb 18, 2021

elasticmachine commented Feb 18, 2021

elasticmachine commented Feb 18, 2021

jonathan-buttner left a comment

Choose a reason for hiding this comment

jonathan-buttner left a comment • edited Loading

Choose a reason for hiding this comment

jonathan-buttner Feb 26, 2021

Choose a reason for hiding this comment

cnasikas Feb 26, 2021 • edited Loading

Choose a reason for hiding this comment

jonathan-buttner Feb 26, 2021

Choose a reason for hiding this comment

cnasikas Feb 26, 2021

Choose a reason for hiding this comment

cnasikas commented Feb 26, 2021 • edited Loading

kibanamachine commented Feb 26, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

cnasikas commented Feb 18, 2021 •

edited

Loading

jonathan-buttner left a comment •

edited

Loading

cnasikas Feb 26, 2021 •

edited

Loading

cnasikas commented Feb 26, 2021 •

edited

Loading