adjust waterfall chart sidebar CSS to appropriately display border #92191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
dominiqueclarke
added
bug
dominiqueclarke
commented
Feb 22, 2021
| z-index: ${(props) => props.theme.eui.euiZLevel5}; | ||
| `; | ||
| min-width: 0; |
There was a problem hiding this comment.
My original max-width solution was kinda an antipattern. This is the appropriate way to handle flexbox and no-wrap children.
|
@elasticmachine merge upstream |
dominiqueclarke
deleted the
fix/91940-uptime-waterfall-sidebar-border
branch
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 23, 2021
…lastic#92191) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Feb 23, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 23, 2021
…lastic#92191) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #91940
Fixes CSS to appropriately show the sidebar border
Before
After
NOTE: After spending some time on this, I've noticed that the y index shifts by a tiny amount of pixels (2 - 4 or so) depending on the amount of gridlines along the x axis. This is happening on the Elastic Chart side. This creates a situation where this isn't a single right amount of pixels to adjust the margin by. This creates a scenario in which some waterfall charts may have a small amount of pixels (2 - 4 or so), between the sidebar and the y axis.
Here is an example of a waterfall chart where the y axis shifts just slightly, causing a situation in which there is about 4 pixels between the border of the filter and the y axis. Fixing the issue for this chart and data set then creates an issue for another, because the spacing is not consistent.
I've adjusted the margin to help ensure that border is showing in the most amount of cases, despite the small gap between the sidebar and the y axis.