Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] call chrome and firefox scripts from security cypress job #92318

Merged
merged 1 commit into from
Feb 23, 2021
Merged

[ci] call chrome and firefox scripts from security cypress job #92318

merged 1 commit into from
Feb 23, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Feb 22, 2021

Looks like #91524 missed the security cypress job definition when updating the script names. This updates the job to run both scripts.

@spalger spalger added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.13.0 labels Feb 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

spong
spong approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @spalger! 🙂 Apologies for the disruption here!

@spalger spalger enabled auto-merge (squash) February 23, 2021 00:01
@spalger spalger merged commit 13624d5 into elastic:master Feb 23, 2021
@spalger spalger deleted the fix/security-cypress-job branch February 23, 2021 00:22
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 92318 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 25, 2021
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 25, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 7.12: Commit could not be cherrypicked due to conflicts
❌ 7.x: Commit could not be cherrypicked due to conflicts

To backport manually, check out the target branch and run:
node scripts/backport --pr 92318

@spalger spalger added the backport:skip This commit does not require backporting label Feb 25, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 25, 2021
@spalger
Copy link
Contributor Author

spalger commented Feb 25, 2021

Was backported by #92515 and #92516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders approved these changes

@spong spong spong approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spalger @elasticmachine @kibanamachine @brianseeders @spong