[ML] Data Frame Analytic: adds api integration tests for _start and _stop endpoints #92532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
pheyos
reviewed
Feb 24, 2021
There was a problem hiding this comment.
Thanks for adding these tests! 🎉
I left a few suggestions in the code. Also, I think it might be worth to split the test files, so the file name is a bit more descriptive (e.g. post could also be an update to the job) and more aligned to how we named similar other test files. Maybe something like start, stop, start_spaces and stop_spaces (more on the separation of start and stop tests in my code comments).
x-pack/test/api_integration/apis/ml/data_frame_analytics/post.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/post.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/post.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/post.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/post.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/post_spaces.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/post_spaces.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/post_spaces.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/post_spaces.ts
Outdated
Show resolved
Hide resolved
qn895
approved these changes
Feb 24, 2021
|
Code LGTM |
alvarezmelissa87
force-pushed
the
ml-dfa-integration-tests-post
branch
from
e295e8d
to
f97c81c
Compare
pheyos
reviewed
Feb 25, 2021
x-pack/test/api_integration/apis/ml/data_frame_analytics/stop_spaces.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/stop.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/stop_spaces.ts
Outdated
Show resolved
Hide resolved
This was referenced Feb 25, 2021
pheyos
reviewed
Mar 1, 2021
alvarezmelissa87
force-pushed
the
ml-dfa-integration-tests-post
branch
from
86fc1d2
to
9361c38
Compare
|
@pheyos - this is updated and ready for a final look. Running it through the flaky test runner was also all green |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Checked test stability in a flaky test runner job: no ML failures in 50 runs (one unrelated search api failure) ✔️ |
alvarezmelissa87
added a commit
that referenced
this pull request
Mar 3, 2021
…stop endpoints (#92532) (#93451) * add start and stop endpoint tests * add start and stop within spaces endpoint tests * move start and start_spaces tests to separate files * wip: move stop and stop_spaces to separate files * use slow running job config so job is still running when stop request happens * check started job state is actually started * check job is stopped after stopping * add debug logs * ensure jobs are created/started before stopping attempt * remove unnecessary debug logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds api integration tests for _start and _stop endpoints
Checklist
Delete any items that are not applicable to this PR.