-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ts] disable forceConsistentCasingInFileNames, it seems broken #92849
[ts] disable forceConsistentCasingInFileNames, it seems broken #92849
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
…ic#92849) Co-authored-by: spalger <spalger@users.noreply.github.com>
… (#92892) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Spencer <email@spalger.com> Co-authored-by: spalger <spalger@users.noreply.github.com>
We have been doing this gradually. I usually rename everything I touch in a PR. |
Thank you @smith! |
Much appreciated! |
Fixes #92837
The APM team does not use snake_case filenames like we do in the rest of the repo, so we enabled the
forceConsistentCasingInFileNames
setting which is supposed to prevent using multiple casings for the same file. It seems though that this consistency is only enforced in certain scenarios which don't include CI or bootstrap in most cases, which is an issue for enforcement.I think if the APM team really wants to enforce filename consistency they should consider switching to snake_case filenames like we use in the rest of the repo.
cc @elastic/apm-ui