-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Fix link from dashboard saved search to Discover #92937
Merged
wylieconlon
merged 9 commits into
elastic:master
from
wylieconlon:discover/fix-context-url
Mar 3, 2021
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6ed0143
[Discover] Fix link from dashboard saved search to Discover
wylieconlon 9f0e123
Merge remote-tracking branch 'origin/master' into discover/fix-contex…
wylieconlon b8c8a55
Fix tests that weren't fully testing the navigation
wylieconlon 16cc57f
Merge remote-tracking branch 'origin/master' into discover/fix-contex…
wylieconlon 62791c3
Fix snapshot
wylieconlon 15eddd7
Fix test navigation to context app by reverting to previous
wylieconlon b412308
Merge remote-tracking branch 'origin/master' into discover/fix-contex…
wylieconlon f14d6f0
Unskip functional test and fix issue in data grid
wylieconlon bad0c13
Respond to review comments
wylieconlon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
.../discover/public/application/components/doc_viewer/__snapshots__/doc_viewer.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,19 +12,32 @@ const filterManager = ({ | |
getGlobalFilters: () => [], | ||
getAppFilters: () => [], | ||
} as unknown) as FilterManager; | ||
const addBasePath = (path: string) => `/base/${path}`; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: |
||
|
||
describe('Get context url', () => { | ||
test('returning a valid context url', async () => { | ||
const url = await getContextUrl('docId', 'ipId', ['test1', 'test2'], filterManager); | ||
const url = await getContextUrl( | ||
'docId', | ||
'ipId', | ||
['test1', 'test2'], | ||
filterManager, | ||
addBasePath | ||
); | ||
expect(url).toMatchInlineSnapshot( | ||
`"#/context/ipId/docId?_g=(filters:!())&_a=(columns:!(test1,test2),filters:!())"` | ||
`"/base//app/discover#/context/ipId/docId?_g=(filters:!())&_a=(columns:!(test1,test2),filters:!())"` | ||
); | ||
}); | ||
|
||
test('returning a valid context url when docId contains whitespace', async () => { | ||
const url = await getContextUrl('doc Id', 'ipId', ['test1', 'test2'], filterManager); | ||
const url = await getContextUrl( | ||
'doc Id', | ||
'ipId', | ||
['test1', 'test2'], | ||
filterManager, | ||
addBasePath | ||
); | ||
expect(url).toMatchInlineSnapshot( | ||
`"#/context/ipId/doc%20Id?_g=(filters:!())&_a=(columns:!(test1,test2),filters:!())"` | ||
`"/base//app/discover#/context/ipId/doc%20Id?_g=(filters:!())&_a=(columns:!(test1,test2),filters:!())"` | ||
); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
docTableAnchorRow
should not be necessary here, it's just used in context view and thereinfinite-scroll
is set to true. It's here added to the paginated doc table that's used in the embeddable.