[ML] Transforms: Fixes chart histograms for runtime fields. #93028

walterra · 2021-03-01T13:35:46Z

Summary

Fixes chart histograms for runtime fields. The runtime field configurations were not passed on to the endpoint to fetch the charts data, so charts ended up being empty with a 0 documents legend.

Makes sure the wizard's runtime configuration gets passed on to the API endpoint to fetch the chart histogram data
Moves histogram charts related types and type guards to ml/common/types/field_histograms.ts for better reuse.
Moves runtimeMappingsSchema to api_schemas/common for better reuse.

Checklist

Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately

…orm wizard.

elasticmachine · 2021-03-01T13:35:48Z

Pinging @elastic/ml-ui (:ml)

qn895 · 2021-03-01T17:22:52Z

Tested and the extra validation LGTM. One small thing is I wasn't able to get histogram charts for the numeric and boolean runtime mapping to show up while testing.

walterra · 2021-03-02T08:06:10Z

@qn895 good catch! I fixed histograms for numeric fields in bfb8654, I missed adding runtime fields to the additional query required to fetch the range of values for numeric fields.

kibanamachine · 2021-03-02T10:03:10Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	1739	1740	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	6.4MB	6.4MB	-249.0B
`transform`	944.2KB	944.9KB	+680.0B
total			+431.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`ml`	68.8KB	69.9KB	+1.1KB

History

💚 Build #109992 succeeded 3c4b5c7
💚 Build #109926 succeeded 18d936b
💔 Build #109893 failed 1459ef0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

darnautov · 2021-03-02T10:10:32Z

x-pack/plugins/ml/common/types/field_histograms.ts

+  type: 'numeric';
+}
+
+export const isNumericChartData = (arg: any): arg is NumericChartData => {


shall we use unknown instead of any for type guards?

It's a good idea, but since we used any so far for all type guards, I'd rather do this in a follow up and change it for all type guards we have if we want to do it. There might be some changes necessary to how we check objects.

pheyos

Tested and LGTM

peteharverson

Tested and LGTM

…93028) Fixes chart histograms for runtime fields. The runtime field configurations were not passed on to the endpoint to fetch the charts data, so charts ended up being empty with a 0 documents legend.

kibanamachine · 2021-03-02T12:41:03Z

💚 Backport successful

✅ 7.12 / #93202
✅ 7.x / #93203

Successful backport PRs will be merged automatically after passing CI.

…93202) Fixes chart histograms for runtime fields. The runtime field configurations were not passed on to the endpoint to fetch the charts data, so charts ended up being empty with a 0 documents legend. Co-authored-by: Walter Rafelsberger <walter@elastic.co>

…93203) Fixes chart histograms for runtime fields. The runtime field configurations were not passed on to the endpoint to fetch the charts data, so charts ended up being empty with a 0 documents legend. Co-authored-by: Walter Rafelsberger <walter@elastic.co>

…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (elastic#93150) Cleanup Security plugin imports (elastic#93056) [Security Solution] - Bug fixes (elastic#92294) Updated doc links (elastic#92968) [ML] Transforms: Fixes chart histograms for runtime fields. (elastic#93028) [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)

walterra added 2 commits March 1, 2021 14:20

[ML] Fix chart histograms for runtime fields configurations in transf…

01c8574

…orm wizard.

[ML] Fix double assignment.

1459ef0

walterra added bug Fixes for quality problems that affect the customer experience :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v7.12.0 v7.13.0 labels Mar 1, 2021

walterra requested review from peteharverson, jgowdyelastic and qn895 March 1, 2021 13:35

walterra self-assigned this Mar 1, 2021

walterra requested a review from a team as a code owner March 1, 2021 13:35

walterra added 2 commits March 1, 2021 16:15

[ML] Remove obsolete export.

18d936b

[ML] Improve runtime mappings validation.

3c4b5c7

walterra requested a review from pheyos March 1, 2021 16:48

[ML] Fix histograms for numeric fields.

bfb8654

walterra mentioned this pull request Mar 2, 2021

[ML] Data Grid Histograms #71231

Open

13 tasks

darnautov reviewed Mar 2, 2021

View reviewed changes

pheyos approved these changes Mar 2, 2021

View reviewed changes

peteharverson approved these changes Mar 2, 2021

View reviewed changes

walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 2, 2021

walterra merged commit 8201d4f into elastic:master Mar 2, 2021

walterra deleted the ml-fix-histogram-runtime-fields branch March 2, 2021 12:37

kibanamachine mentioned this pull request Mar 2, 2021

[7.12] [ML] Transforms: Fixes chart histograms for runtime fields. (#93028) #93202

Merged

kibanamachine mentioned this pull request Mar 2, 2021

[7.x] [ML] Transforms: Fixes chart histograms for runtime fields. (#93028) #93203

Merged

peteharverson mentioned this pull request Mar 2, 2021

[ML] Support runtime fields #77462

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Transforms: Fixes chart histograms for runtime fields. #93028

[ML] Transforms: Fixes chart histograms for runtime fields. #93028

walterra commented Mar 1, 2021 •

edited

Loading

elasticmachine commented Mar 1, 2021

qn895 commented Mar 1, 2021

walterra commented Mar 2, 2021

kibanamachine commented Mar 2, 2021

darnautov Mar 2, 2021

walterra Mar 2, 2021

pheyos left a comment

peteharverson left a comment

kibanamachine commented Mar 2, 2021

[ML] Transforms: Fixes chart histograms for runtime fields. #93028

[ML] Transforms: Fixes chart histograms for runtime fields. #93028

Conversation

walterra commented Mar 1, 2021 • edited Loading

Summary

Checklist

elasticmachine commented Mar 1, 2021

qn895 commented Mar 1, 2021

walterra commented Mar 2, 2021

kibanamachine commented Mar 2, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

darnautov Mar 2, 2021

Choose a reason for hiding this comment

walterra Mar 2, 2021

Choose a reason for hiding this comment

pheyos left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

kibanamachine commented Mar 2, 2021

💚 Backport successful

walterra commented Mar 1, 2021 •

edited

Loading