[APM] Fixes duplicate ML job creation for existing environments (#85023)

[ogupte]

Closes #85023.

Checks for existing ML jobs for the currently selected environments in the API before creating a duplicate jobs. This was only happening on the client-side previously.

Example:

Pre-condition: ML Jobs already exist for APM environments: "test" & "prod"
---
POST /api/apm/settings/anomaly-detection/jobs
{ "environments": [ "test", "prod", "staging" ] }
---
server    log   [14:49:58.851] [warning][apm][plugins] Skipping creation of existing ML jobs for environments: [test,prod]}
server    log   [14:49:58.853] [info][apm][plugins] Creating ML anomaly detection jobs for environments: [staging].

[elasticmachine]

Pinging @elastic/apm-ui (Team:apm)

[smith]

I wish partition was a native array method. You can get it from lodash but this is fine.

[sorenlouv]

I didn't know about _.partition. It's neat but I had to go to the lodash docs to understand it.
The current code I can read with no manual. So while slightly longer it comes with a lower overhead (for me at least)

[sorenlouv]

Btw. I agree partition would be better if it was native

[sorenlouv]

nit: What about extracting this out?

async function getUniqueMlJobEnvs(
  setup: Setup,
  environments: string[],
  logger: Logger
) {
  // skip creation of duplicate ML jobs
  const jobs = await getAnomalyDetectionJobs(setup, logger);
  const existingMlJobEnvs = jobs.map(({ environment }) => environment);
  const requestedExistingMlJobEnvs = environments.filter((env) =>
    existingMlJobEnvs.includes(env)
  );

  if (requestedExistingMlJobEnvs.length) {
    logger.warn(
      `Skipping creation of existing ML jobs for environments: [${requestedExistingMlJobEnvs}]}`
    );
  }

  return environments.filter((env) => !existingMlJobEnvs.includes(env));
}

[sorenlouv]

Good job! Let's hope this fixes it for good 🤞

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 0045571
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
triggersActionsUi	1.6MB	1.5MB	-23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
triggersActionsUi	104.0KB	104.1KB	+82.0B

Unknown metric groups

async chunk count

id	before	after	diff
triggersActionsUi	41	42	+1

History

• 💚 Build #110095 succeeded c29bdfd
• 💚 Build #110064 succeeded 7b1f0b4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream