Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable APM storybook publishing #93353

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Enable APM storybook publishing #93353

merged 4 commits into from
Mar 8, 2021

Conversation

smith
Copy link
Contributor

@smith smith commented Mar 3, 2021

Changes to fix APM's Storybook setup were made in #93087 and #93294. This re-enables it and fixes a couple places where we weren't using a theme provider.

@smith
Enable APM storybook publishing
eb689f4 
Changes to fix APM's Storybook setup were made in elastic#93087 and elastic#93294. This re-enables it and fixes a couple places where we weren't using a theme provider.
@smith smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 3, 2021
@smith smith requested a review from a team as a code owner March 3, 2021 00:14
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Mar 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith
Copy link
Contributor Author

smith commented Mar 5, 2021

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Mar 8, 2021

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Mar 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 749a229 into elastic:master Mar 8, 2021
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 8, 2021
@smith @kibanamachine
Enable APM storybook publishing (elastic#93353)
1a7d1b6 
Changes to fix APM's Storybook setup were made in elastic#93087 and elastic#93294. This re-enables it and fixes a couple places where we weren't using a theme provider.
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #93964

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 8, 2021
@kibanamachine @smith
Enable APM storybook publishing (#93353) (#93964)
2c3efd3 
Changes to fix APM's Storybook setup were made in #93087 and #93294. This re-enables it and fixes a couple places where we weren't using a theme provider.

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smith @elasticmachine @kibanamachine @dgieselaar