Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Correctly track install status of an integration #93464

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Mar 3, 2021

Summary

Fixes #90992

The Detail view in EPMApp didn't correctly track if a package was installed or not. The effect of this was that some parts of the UI weren't made available right after a user installed a package. This PR correctly tracks this.

@afgomez afgomez added release_note:fix v8.0.0 Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 labels Mar 3, 2021
@afgomez afgomez requested a review from a team as a code owner March 3, 2021 17:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:EPM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! 🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 754.6KB 754.8KB +176.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit a050b7a into elastic:master Mar 4, 2021
@afgomez afgomez deleted the 90992-integrations-install-status branch March 4, 2021 10:01
afgomez pushed a commit to afgomez/kibana that referenced this pull request Mar 4, 2021
afgomez pushed a commit to afgomez/kibana that referenced this pull request Mar 4, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
* master: (48 commits)
  Fix wrong import in data plugin causing 100kB bundle increase (elastic#93448)
  [Fleet] Correctly track install status of an integration (elastic#93464)
  Reviews data frame analytics UI text (elastic#93033)
  Display multiple copyable fields for process.args in resolver node detail panel (elastic#93280)
  [Security Solution][Detections] ML Popover overflow fix (elastic#93525)
  chore(NA): do not use execa on bazel workspace status update script (elastic#93532)
  Bump dependencies (elastic#93511)
  [dev/build_ts_refs] support disabling the ts-refs build completely (elastic#93529)
  [Security Solution] fix data provider cypress test (elastic#93465)
  Fix service map for All environment single service (elastic#93517)
  [Fleet] Fix package version comparaison in the UI (elastic#93498)
  [alerting] adds doc on JSON-expanded action variables and task manager max_workers (elastic#92720)
  [dev/build_ts_refs] ignore type checking failures when building ts refs (elastic#93473)
  [core-new-docs] Adds a dev-doc for core documentation (elastic#92976)
  remove opacity from maps legacy style (elastic#93456)
  [Security Solution][Lists] Escape quotes in list ids and quote the id in KQL query (elastic#93176)
  Revert "Make tests deterministic by providing unique timestamps (elastic#93350)"
  [Discover] Fix link from dashboard saved search to Discover (elastic#92937)
  update public api docs
  App Search - Polishing Analytics Views (elastic#92939)
  ...
@EricDavisX
Copy link
Contributor

can I get some help translating the issue here to know how to reproduce it and test it? @jen-huang @afgomez please and thank you! I'm looking for specific steps the test team can follow, and possibly set up a manual test for it.

  • I agree the code is simple enough for backport to 7.12 even after a 3rd BC is out but since it is so late, I want to test it well. Did we write a test for this or is it painful because it deals with package versions and is tricky to manipulate in a test? Maybe a Jest unit test would suffice?
    @ph @dikshachauhan-qasource fyi

Thanks all!

afgomez pushed a commit that referenced this pull request Mar 4, 2021
…3573)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jen-huang
Copy link
Contributor

@EricDavisX Steps can be found in the original issue description #90992. It's not a package version issue but rather a UI issue, and since we don't have UI tests yet, there is no unit test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Integration "Policies" tab doesn't show up right away after successful install
5 participants