Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Carry previous configured formatter in Last value #93784

Merged
merged 5 commits into from
Mar 8, 2021
Merged

[Lens] Carry previous configured formatter in Last value #93784

merged 5 commits into from
Mar 8, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Mar 5, 2021

Summary

Fixes #93621

This PR unifies the same logic to extract the format settings from the previous column into a shared utility and extends the current support also to last_value.

Checklist

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.13.0 labels Mar 5, 2021
@dej611 dej611 requested a review from a team March 5, 2021 15:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dej611 dej611 changed the title [Lens] Unify formatter transferable logic in operations [Lens] Carry previous configured formatter in Last value Mar 5, 2021
wylieconlon
wylieconlon approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually run the code here, but it looks completely safe.

wylieconlon
wylieconlon reviewed Mar 5, 2021
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it does seem to work!

@dej611
Copy link
Contributor Author

dej611 commented Mar 8, 2021

@elasticmachine merge upstream

@dej611 dej611 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 8, 2021
flash1293
flash1293 reviewed Mar 8, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, but it looks like x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/count.tsx could use the same helper.

flash1293
flash1293 approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because I don't think another round of review is required after that gets fixed

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 920.9KB 919.9KB -979.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit adfbe97 into elastic:master Mar 8, 2021
@dej611 dej611 deleted the fix/93621 branch March 8, 2021 16:38
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 8, 2021
@dej611 @kibanamachine
[Lens] Carry previous configured formatter in Last value (elastic#93784)
2a28925 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #93963

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 8, 2021
@kibanamachine @dej611
[Lens] Carry previous configured formatter in Last value (#93784) (#9…
05ece63 
…3963)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wylieconlon wylieconlon wylieconlon approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Last value operation loses user's format settings
5 participants
@dej611 @elasticmachine @kibanamachine @wylieconlon @flash1293