[Security Solution][Exceptions][Builder] -Move exception builder entry item exceptions ui over to lists #94515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yctercero
changed the title
yctercero
added
release_note:skip
yctercero
force-pushed
the
rac_exceptions_ui
branch
from
77ef114
to
11e2a2e
Compare
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
This was referenced Mar 23, 2021
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @yctercero |
dplumlee
approved these changes
Mar 26, 2021
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
Mar 26, 2021
…y item exceptions ui over to lists (elastic#94515) ## Summary Beginning to move the exceptions UI out of the security solution plugin and into the lists plugin. In order to keep PRs (relatively) small, I plan to move single components at a time. This should also then help more easily pinpoint the source of any issues that come up along the way. The next couple PRs will focus on the exception builder. This one in particular is focused on moving over the `BuilderEntryItem` which deals with rendering the individual exception item entries. An entry can be of type `match`, `match_any`, `list`, `exists`, or `nested`. The component makes use of the autocomplete fields which use the index patterns to display possible fields and field values. One of the decisions made in this PR was to have consumers of the `BuilderEntryItem` pass through the autocomplete service as opposed to the `lists` plugin adding it as a dependency. The reason being that it is likely that plugins using the lists plugin will already be consuming either the data plugin or if alerting takes exceptions in, then they'll be consuming alerting. In an effort to avoid some possible icky circular dependency issues, though it best to make the service passed in, as we had already been doing with the hooks in the `lists` plugin.
yctercero
added a commit
that referenced
this pull request
Mar 27, 2021
…y item exceptions ui over to lists (#94515) (#95585) ## Summary Beginning to move the exceptions UI out of the security solution plugin and into the lists plugin. In order to keep PRs (relatively) small, I plan to move single components at a time. This should also then help more easily pinpoint the source of any issues that come up along the way. The next couple PRs will focus on the exception builder. This one in particular is focused on moving over the `BuilderEntryItem` which deals with rendering the individual exception item entries. An entry can be of type `match`, `match_any`, `list`, `exists`, or `nested`. The component makes use of the autocomplete fields which use the index patterns to display possible fields and field values. One of the decisions made in this PR was to have consumers of the `BuilderEntryItem` pass through the autocomplete service as opposed to the `lists` plugin adding it as a dependency. The reason being that it is likely that plugins using the lists plugin will already be consuming either the data plugin or if alerting takes exceptions in, then they'll be consuming alerting. In an effort to avoid some possible icky circular dependency issues, though it best to make the service passed in, as we had already been doing with the hooks in the `lists` plugin. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Beginning to move the exceptions UI out of the security solution plugin and into the lists plugin. In order to keep PRs (relatively) small, I plan to move single components at a time. This should also then help more easily pinpoint the source of any issues that come up along the way.
The next couple PRs will focus on the exception builder. This one in particular is focused on moving over the
BuilderEntryItemwhich deals with rendering the individual exception item entries. An entry can be of typematch,match_any,list,exists, ornested. The component makes use of the autocomplete fields which use the index patterns to display possible fields and field values.One of the decisions made in this PR was to have consumers of the
BuilderEntryItempass through the autocomplete service as opposed to thelistsplugin adding it as a dependency. The reason being that it is likely that plugins using the lists plugin will already be consuming either the data plugin or if alerting takes exceptions in, then they'll be consuming alerting. In an effort to avoid some possible icky circular dependency issues, though it best to make the service passed in, as we had already been doing with the hooks in thelistsplugin.Quick Summary:
x-pack/plugins/security_solution/public/common/components/exceptions/builder/entry_item.tsx→x-pack/plugins/lists/public/exceptions/components/builder/entry_renderer.tsxBuilderEntryItemfrom lists pluginx-pack/plugins/security_solution/public/common/components/autocomplete/tox-pack/plugins/lists/public/exceptions/components/autocomplete/Entry Item (THIS PR DEALS WITH 👇🏽)
Exception Item
Builder Buttons
Exception Item Comments
Builder Modal
Notes
listsplugin here I think could live elsewhere. Personally, I think it'd be best if they were components that EUI supported as they are consumed in numerous other places within the security app. To avoid disrupting these other consumers, I did a copy paste of them for now to be used by thelistsplugin. [EUI][Data] - Add index field selectors to EUI or Data #94875Testing
Prior to making these changes, added a number of tests to ensure coverage of existing functionality. For manual testing, please checkout PR and play around with the following:
match,match_any,nestedetc.Checklist