[ML] Add Anomaly charts embeddables to Dashboard from Anomaly Explorer page #95623

qn895 · 2021-03-29T00:08:22Z

Summary

Follow-up of #94396. Part of #94650. This PR adds an option in the anomaly explorer page to add embeddables to Kibana dashboards:

It also:

Remove some cached synchronous service like mlJobService
Remove side effects like explorerService in the getAnomalyData function which previously was used to set charts data in the explorer page
Remove the deprecated resultSelector in the mergeMap util
Consolidates the Add to dashboard controls that were also used to add swimlane embeddables to the dashboard.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

…support

…de of tap

…d transform"

…able-refactor-ui-actions

.../public/application/explorer/dashboard_controls/add_anomaly_charts_to_dashboard_controls.tsx

…ithub.com/qn895/kibana into ml-anomaly-embeddable-refactor-ui-actions

walterra · 2021-04-06T13:14:25Z

x-pack/plugins/ml/common/util/runtime_field_utils.test.ts

@@ -7,96 +7,65 @@

 import { isRuntimeField, isRuntimeMappings } from './runtime_field_utils';

-describe('ML runtime field utils', () => {


I suspect something went wrong with a master rebase/merge. The removed lines are actually the newer code merged as part of this PR: https://github.com/elastic/kibana/pull/95651/files#diff-02075861bae59012670e1e16f2017e22cfca82cf3d7a210eb9c66e96503252d1R10

Updated here dbd5e91 (#95623)

walterra · 2021-04-06T13:15:51Z

x-pack/plugins/ml/common/util/runtime_field_utils.ts

        (typeof arg.script === 'string' ||
-          (isPopulatedObject(arg.script, ['source']) &&
+          (isPopulatedObject(arg.script) &&


Looks like a master rebase/merge went wrong here, the removed code is actually the newer one, see this PR again: https://github.com/elastic/kibana/pull/95651/files#diff-7dfaf266f36a691f0ea87f071af9f1915e031dffb83ad4c35281b932114deb07R16

Thanks for catching that. I have updated it here dbd5e91 (#95623)

…able-refactor-ui-actions

qn895 · 2021-04-06T20:19:03Z

@elasticmachine merge upstream

walterra

Code LGTM

qn895 · 2021-04-07T16:44:08Z

@elasticmachine merge upstream

…able-refactor-ui-actions

kibanamachine · 2021-04-08T16:48:49Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	1784	1789	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	5.9MB	6.0MB	+9.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`ml`	66.8KB	66.9KB	+138.0B

History

💔 Build #117941 failed 47ecb4d
💚 Build #117671 succeeded 653d612
💔 Build #117618 failed e901434
💚 Build #117558 succeeded 83c6974
💚 Build #117320 succeeded b7f8427

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

…r page (elastic#95623) Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-04-08T17:25:35Z

💚 Backport successful

✅ 7.x / #96614

This backport PR will be merged automatically after passing CI.

kibanamachine · 2021-04-12T17:30:16Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

…r page (#95623) (#96614) Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com> Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>

qn895 added 20 commits March 23, 2021 17:43

[ML] Add runtime support from index pattern for data viz

0f5046f

Merge upstream/master into branch

c542ca5

[ML] move runtime mappings outside of aggregatableFields loop

1e708e1

[ML] Change arg name to runtimeMappings

a6ae3ce

Merge remote-tracking branch 'upstream/master' into data-viz-runtime-…

705d84c

…support

[ML] Fix dv full time range broken

861d28f

[ML] Fix dv broken with time range

97c5890

[ML] Add better error handling/transparency

b68e736

[ML] Update to using estypes.RuntimeField

54b62f8

[ML] Update to use some shared common functions between ml and transform

ce813f0

[ML] Remove mlJobService.getJob dependency

2b669c8

[ML] Remove deprecated resultSelector, move anomalyChartRecords outsi…

dad2872

…de of tap

[ML] Move to loadDataForCharts$

95587c7

[ML] Add setChartsDataLoading

cdee080

Revert "[ML] Update to use some shared common functions between ml an…

343bb61

…d transform"

Merge remote-tracking branch 'upstream/master' into ml-anomaly-embedd…

99982e0

…able-refactor-ui-actions

[ML] Consolidate explorer and swimlane add to dashboard controls

b680c38

[ML] Update mocks

fc3ec9e

[ML] Update disabled check

a7cbcd0

[ML] Disable context menu if no charts

2c5e8de

qn895 self-assigned this Mar 29, 2021

qn895 requested review from darnautov, walterra and peteharverson and removed request for darnautov March 29, 2021 00:08

qn895 added the :ml label Mar 29, 2021

peteharverson reviewed Mar 29, 2021

View reviewed changes

.../public/application/explorer/dashboard_controls/add_anomaly_charts_to_dashboard_controls.tsx Show resolved Hide resolved

qn895 added 2 commits March 29, 2021 14:50

Merge branch 'ml-anomaly-embeddable-refactor-ui-actions' of https://g…

f2a91bb

…ithub.com/qn895/kibana into ml-anomaly-embeddable-refactor-ui-actions

Merge upstream/master into branch

6c9bd89

[ML] Fix type

b7f8427

walterra requested changes Apr 6, 2021

View reviewed changes

qn895 added 2 commits April 6, 2021 09:12

[ML] Fix merge overrides

dbd5e91

Merge remote-tracking branch 'upstream/master' into ml-anomaly-embedd…

83c6974

…able-refactor-ui-actions

qn895 requested a review from walterra April 6, 2021 14:14

Merge remote-tracking branch 'upstream/master' into ml-anomaly-embedd…

e901434

…able-refactor-ui-actions

Merge branch 'master' into ml-anomaly-embeddable-refactor-ui-actions

653d612

walterra approved these changes Apr 7, 2021

View reviewed changes

kibanamachine and others added 5 commits April 7, 2021 12:44

Merge branch 'master' into ml-anomaly-embeddable-refactor-ui-actions

47ecb4d

Merge remote-tracking branch 'upstream/master' into ml-anomaly-embedd…

d8de444

…able-refactor-ui-actions

[ML] Fix AnnotationDomainType -> AnnotationDomainTypes

2e0bb30

Merge remote-tracking branch 'upstream/master' into ml-anomaly-embedd…

422c705

…able-refactor-ui-actions

Revert "[ML] Fix AnnotationDomainType -> AnnotationDomainTypes"

5efc9e6

qn895 added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 8, 2021

qn895 merged commit d904f8d into elastic:master Apr 8, 2021

qn895 deleted the ml-anomaly-embeddable-refactor-ui-actions branch April 8, 2021 17:22

kibanamachine mentioned this pull request Apr 8, 2021

[7.x] [ML] Add Anomaly charts embeddables to Dashboard from Anomaly Explorer page (#95623) #96614

Merged

kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 12, 2021

peteharverson mentioned this pull request Apr 15, 2021

[ML] Anomaly Explorer can continuously re-render on swim lane cell selection #97266

Closed

qn895 restored the ml-anomaly-embeddable-refactor-ui-actions branch April 19, 2021 18:08

qn895 mentioned this pull request Apr 23, 2021

[ML] Fix Anomaly Explorer continuously re-render on swim lane cell selection #98196

Merged

1 task

qn895 deleted the ml-anomaly-embeddable-refactor-ui-actions branch May 24, 2021 21:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Add Anomaly charts embeddables to Dashboard from Anomaly Explorer page #95623

[ML] Add Anomaly charts embeddables to Dashboard from Anomaly Explorer page #95623

qn895 commented Mar 29, 2021 •

edited

Loading

walterra Apr 6, 2021

qn895 Apr 6, 2021

walterra Apr 6, 2021

qn895 Apr 6, 2021 •

edited

Loading

qn895 commented Apr 6, 2021

walterra left a comment

qn895 commented Apr 7, 2021

kibanamachine commented Apr 8, 2021

kibanamachine commented Apr 8, 2021

kibanamachine commented Apr 12, 2021

		@@ -7,96 +7,65 @@

		import { isRuntimeField, isRuntimeMappings } from './runtime_field_utils';

		describe('ML runtime field utils', () => {

[ML] Add Anomaly charts embeddables to Dashboard from Anomaly Explorer page #95623

[ML] Add Anomaly charts embeddables to Dashboard from Anomaly Explorer page #95623

Conversation

qn895 commented Mar 29, 2021 • edited Loading

Summary

Checklist

walterra Apr 6, 2021

Choose a reason for hiding this comment

qn895 Apr 6, 2021

Choose a reason for hiding this comment

walterra Apr 6, 2021

Choose a reason for hiding this comment

qn895 Apr 6, 2021 • edited Loading

Choose a reason for hiding this comment

qn895 commented Apr 6, 2021

walterra left a comment

Choose a reason for hiding this comment

qn895 commented Apr 7, 2021

kibanamachine commented Apr 8, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

kibanamachine commented Apr 8, 2021

💚 Backport successful

kibanamachine commented Apr 12, 2021

qn895 commented Mar 29, 2021 •

edited

Loading

qn895 Apr 6, 2021 •

edited

Loading