Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "TS Incremental build exclude test files (#95610)" #96223

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Revert "TS Incremental build exclude test files (#95610)" #96223

merged 2 commits into from
Apr 5, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Apr 5, 2021

Devs complain about unrelated errors in different modules

@mshustov mshustov requested a review from a team as a code owner April 5, 2021 16:04
@mshustov mshustov requested a review from a team April 5, 2021 16:04
@mshustov mshustov requested review from a team as code owners April 5, 2021 16:04
@mshustov mshustov requested a review from a team April 5, 2021 16:04
@mshustov mshustov requested review from a team as code owners April 5, 2021 16:04
@botelastic botelastic bot added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Apr 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@mshustov mshustov closed this Apr 5, 2021
lizozom
lizozom approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert looks ok

@mshustov mshustov deleted the revert-95610 branch April 5, 2021 16:05
@mshustov mshustov restored the revert-95610 branch April 5, 2021 16:05
@mshustov mshustov deleted the revert-95610 branch April 5, 2021 16:05
@mshustov mshustov restored the revert-95610 branch April 5, 2021 16:06
@mshustov mshustov reopened this Apr 5, 2021
@mshustov mshustov marked this pull request as draft April 5, 2021 16:07
scottybollinger
scottybollinger approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enterprise Search changes LGTM. Thanks!

YulNaumenko
YulNaumenko approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting related LGTM

jportner
jportner approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security/Spaces changes LGTM

alisonelizabeth
alisonelizabeth approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES UI changes LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressions 150 151 +1
uptime 606 607 +1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 880.2KB 880.2KB +47.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 192.7KB 193.0KB +349.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov marked this pull request as ready for review April 5, 2021 18:58
@mshustov mshustov added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Apr 5, 2021
@spalger
Copy link
Contributor

spalger commented Apr 5, 2021

This was a pretty straightforward revert, and since it's been verified locally to fix the problem of broken imports within test files I'm going to merge it without waiting for all code owners to review.

@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 5, 2021
@spalger spalger merged commit e457f21 into elastic:master Apr 5, 2021
@mshustov mshustov deleted the revert-95610 branch April 5, 2021 19:00
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 5, 2021
@mshustov @kibanamachine
Revert "TS Incremental build exclude test files (elastic#95610)" (ela…
8617c8d 
…stic#96223)

This reverts commit b6e582c.
@kibanamachine kibanamachine mentioned this pull request Apr 5, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #96247

This backport PR will be merged automatically after passing CI.

@mshustov mshustov mentioned this pull request Apr 6, 2021
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 6, 2021
@mshustov
Revert "TS Incremental build exclude test files (elastic#95610)" (ela…
a26c99b 
…stic#96223)

This reverts commit b6e582c.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 6, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into sr/fix-wizard…
97ee8a6 
…-nav

* 'master' of github.com:elastic/kibana: (106 commits)
  [Lens] don't use eui variables for zindex (elastic#96117)
  Remove /src/legacy (elastic#95510)
  skip flaky suite (elastic#95899)
  [Dashboard] Fix Lens and TSVB chart tooltip positioning relative to global headers (elastic#94247)
  fixes a skipped management x-pack test (elastic#96178)
  [App Search] API logs: Add log detail flyout (elastic#96162)
  [tech-debt] Remove defunct opacity parameters from EUI shadow functions (elastic#96191)
  Add Input Controls project configuration (elastic#96238)
  [file upload] document file upload privileges and provide actionable UI when failures occur (elastic#95883)
  Revert "TS Incremental build exclude test files (elastic#95610)" (elastic#96223)
  [App Search] Added Sample Response section to Result Settings (elastic#95971)
  [Maps] Safe-erase text-field (elastic#94873)
  [RAC][Alert Triage][TGrid] Update the Alerts Table (TGrid) API to implement `renderCellValue` (elastic#96098)
  [Maps] Enable all zoom levels for all users (elastic#96093)
  Use plugin version in its publicPath (elastic#95945)
  [Enterprise Search] Expose core.chrome.setIsVisible for use in Workplace Search (elastic#95984)
  [Workplace Search] Add sub nav and fix rendering bugs in Personal dashboard (elastic#96100)
  [OBS]home page is showing incorrect value of APM throughput (tpm) (elastic#95991)
  [Observability] Exploratory View initial skeleton (elastic#94426)
  [KQL] Fixed styles of KQL textarea for the K8 theme (elastic#96190)
  ...

# Conflicts:
#	x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/restore_snapshot.helpers.ts
mshustov added a commit that referenced this pull request Apr 6, 2021
@mshustov
[7.x] Revert "TS Incremental build exclude test files (#95610)" (#96223…
ad78665 
…) (#96281)

* Revert "TS Incremental build exclude test files (#95610)" (#96223)

This reverts commit b6e582c.

* code: use base tsconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottybollinger scottybollinger scottybollinger approved these changes

@lizozom lizozom lizozom approved these changes

@jbudz jbudz jbudz approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@jportner jportner jportner approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mshustov @elasticmachine @kibanamachine @spalger @scottybollinger @lizozom @jbudz @alisonelizabeth @jportner @YulNaumenko