Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix switches positioning on the Transform and DFA wizards #96535

Merged
merged 2 commits into from
Apr 8, 2021
Merged

[ML] Fix switches positioning on the Transform and DFA wizards #96535

merged 2 commits into from
Apr 8, 2021

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Apr 8, 2021 •
edited
Loading

Summary

This PR fixes switches positioning on the following pages:

  • "Edit runtime mappings" switch in the Data Frame Analytics wizard
  • "Edit JSON query" switch in the Transform wizard
  • "Edit runtime mappings" switch in the Transform wizard

Before:
Apr-08-2021 09-40-12
tr_before

After:
Apr-08-2021 10-12-23
tr_after

@darnautov darnautov added :ml v8.0.0 Feature:Data Frame Analytics ML data frame analytics features v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 8, 2021
@darnautov darnautov self-assigned this Apr 8, 2021
@darnautov darnautov requested a review from a team as a code owner April 8, 2021 08:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov added the release_note:skip Skip the PR/issue when compiling release notes label Apr 8, 2021
peteharverson
peteharverson reviewed Apr 8, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The transforms editor also needs this fix - I think the file to change is transform/public/app/sections/create_transform/components/advanced_runtime_mappings_settings/advanced_runtime_mappings_settings.tsx

@darnautov darnautov added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Apr 8, 2021
@darnautov darnautov changed the title [ML] Fix "Edit runtime mappings" switch positioning [ML] Fix switches positioning on the Transform and DFA wizards Apr 8, 2021
@darnautov darnautov enabled auto-merge (squash) April 8, 2021 09:22
peteharverson
peteharverson approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +2.0B
transform 907.3KB 907.3KB +5.0B
total +7.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit d9ef5c2 into elastic:master Apr 8, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 8, 2021
@darnautov @kibanamachine
[ML] Fix switches positioning on the Transform and DFA wizards (elast…
a07cc08 
…ic#96535)

* [ML] fix edit runtime mapping switch positioning

* [ML] fix transform wizard switches
@kibanamachine kibanamachine mentioned this pull request Apr 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #96549

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 8, 2021
@kibanamachine @darnautov
[ML] Fix switches positioning on the Transform and DFA wizards (#96535)…
5ae9446 
… (#96549)

* [ML] fix edit runtime mapping switch positioning

* [ML] fix transform wizard switches

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darnautov @elasticmachine @kibanamachine @peteharverson