Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data Frame Analytics: Don't allow user to pick an index pattern or saved search based on CCS. #96555

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Apr 8, 2021

Summary

Fixes #95257.

Data Frame Analytics does not support cross-cluster search.

This PR fixes the SourceSelection component to not allow a user to select a CCS index pattern or a saved search using a CCS index pattern.

Example when a user clicks on an index pattern using CCS (my_remote_cluster:kibana_sample_data_flights):

image

Example when a user clicks on a saved search using an CCS index pattern (kibana_airlines):

image

Checklist

For maintainers

@walterra walterra added bug Fixes for quality problems that affect the customer experience release_note:fix :ml v8.0.0 Feature:Data Frame Analytics ML data frame analytics features v7.13.0 v7.12.1 labels Apr 8, 2021
@walterra walterra requested a review from a team as a code owner April 8, 2021 11:56
@walterra walterra self-assigned this Apr 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 6.0MB +1.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 8, 2021
@walterra walterra merged commit 6b4becf into elastic:master Apr 8, 2021
@walterra walterra deleted the ml-dfa-ccs-error-callout branch April 8, 2021 15:46
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 8, 2021
…or saved search based on CCS. (elastic#96555)

Data Frame Analytics does not support cross-cluster search. This PR fixes the SourceSelection component to not allow a user to select a CCS index pattern or a saved search using a CCS index pattern.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 8, 2021
…or saved search based on CCS. (elastic#96555)

Data Frame Analytics does not support cross-cluster search. This PR fixes the SourceSelection component to not allow a user to select a CCS index pattern or a saved search using a CCS index pattern.
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.12 / #96594
7.x / #96595

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 8, 2021
…or saved search based on CCS. (#96555) (#96595)

Data Frame Analytics does not support cross-cluster search. This PR fixes the SourceSelection component to not allow a user to select a CCS index pattern or a saved search using a CCS index pattern.

Co-authored-by: Walter Rafelsberger <walter@elastic.co>
kibanamachine added a commit that referenced this pull request Apr 8, 2021
…or saved search based on CCS. (#96555) (#96594)

Data Frame Analytics does not support cross-cluster search. This PR fixes the SourceSelection component to not allow a user to select a CCS index pattern or a saved search using a CCS index pattern.

Co-authored-by: Walter Rafelsberger <walter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix v7.12.1 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] need a better error message on DFA job wizard if using CCS
5 participants