-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy setup docs for Elastic Agent and Fleet #1239
Conversation
A documentation preview will be available soon: |
@dedemorton, we need to add a section to state that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed that it works as I've detailed in 7.15.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
environment section looks fine to me. I think we're just missing a section about adding agent.download.proxy_url
but we're fine otherwise
@dedemorton as a general comment, I feel like we should test the steps in this doc to make sure all the functionality works. I'm concerned that when we initially launched this feature we missed something as important as where to set the environment variables. Are you testing it or should we ask the QA team to try it? One advantage of asking QA to do it, is that we might discover steps that need more clarification. |
@EricDavisX Adding you here since it'd be great for the QA to test it once its done. It sounds like Dede didn't have the proper test environment, and the original engineer who worked on it is no longer with the company. CC @nimarezainia since this is a control plane feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@elasticmachine run elasticsearch-ci/docs skiplinkcheck |
* Add proxy setup docs for Elastic Agent and Fleet * Add changes from review * More changes from review * Apply additional chagnes from the review * Add section about where to set env vars * Add revisions from review * Resolve reamining commments from mostlyjason
* Add proxy setup docs for Elastic Agent and Fleet * Add changes from review * More changes from review * Apply additional chagnes from the review * Add section about where to set env vars * Add revisions from review * Resolve reamining commments from mostlyjason
* Add proxy setup docs for Elastic Agent and Fleet * Add changes from review * More changes from review * Apply additional chagnes from the review * Add section about where to set env vars * Add revisions from review * Resolve reamining commments from mostlyjason
* Add proxy setup docs for Elastic Agent and Fleet * Add changes from review * More changes from review * Apply additional chagnes from the review * Add section about where to set env vars * Add revisions from review * Resolve reamining commments from mostlyjason
* Add proxy setup docs for Elastic Agent and Fleet * Add changes from review * More changes from review * Apply additional chagnes from the review * Add section about where to set env vars * Add revisions from review * Resolve reamining commments from mostlyjason
Describes how to set up Elastic Agent and Fleet to communicate through a proxy server.
I have quite a few questions about these steps because I don't have the environment needed to test them. I also need help with examples. But hopefully the basic structure and info is correct.
Preview link: https://observability-docs_1239.docs-preview.app.elstc.co/guide/en/fleet/master/fleet-agent-proxy-support.html
Closes #593