Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Do not recommand user to run Fleet server in http #1758

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Apr 5, 2022

Description

Related to elastic/kibana#129371

We should not recommend user to run Fleet server in http and should use the default self generated certificate instead.

@nchaulet nchaulet added Team:Fleet Label for the Fleet team v8.2.0 labels Apr 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2022

This pull request does not have a backport label. Could you fix it @nchaulet? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Apr 5, 2022
@apmmachine
Copy link
Contributor

A documentation preview will be available soon:

@dedemorton
Copy link
Contributor

I think you want to remove the whole example plus the lead in sentence, "For example, the following command installs a Fleet Server and uses self-signed certs:

image

@nchaulet
Copy link
Member Author

nchaulet commented Apr 7, 2022

@dedemorton I think we want to keep that example the text is correct as it's generating self signed certificate, the option --fleet-server-insecure-http was running fleet server in http mode without generating self signed certificate this was incorrect

@dedemorton
Copy link
Contributor

Ohhhhh. TBH, I have to re-learn this stuff every time I look at it. :-)

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedemorton
Copy link
Contributor

dedemorton commented Apr 7, 2022

I didn't remember having this flag in the command originally, so I looked at the history, and it looks like it was added back in January. Should we try to figure out why, or just say your revision is the correct one? b85317d Nevermind...looked through the issues and it sounds like the older UI showed it, so we wanted to show it too.

@nchaulet nchaulet merged commit 9f0ba49 into main Apr 11, 2022
@nchaulet nchaulet deleted the fix-fleet-server-http branch April 11, 2022 15:27
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Fleet Label for the Fleet team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants