Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Fleet/Agent 8.4.3 release notes #2201

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Adds Fleet/Agent 8.4.3 release notes #2201

merged 4 commits into from
Sep 29, 2022

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Sep 27, 2022 •
edited
Loading

Adds Elastic Agent release notes based on https://github.com/elastic/elastic-agent/commits/5f09295a5dce74a20656ed5bc1d654b1fab06060 in BC2.

There are no Fleet release notes in the Kibana relnotes PR, so I'm assuming no release notes for Fleet. Please confirm.

@dedemorton dedemorton self-assigned this Sep 27, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 27, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Sep 27, 2022 •
edited
Loading

A documentation preview will be available soon:

@dedemorton dedemorton marked this pull request as ready for review September 28, 2022 21:57
@dedemorton dedemorton requested review from a team, blakerouse and michel-laterman and removed request for a team September 28, 2022 21:57
@dedemorton dedemorton added backport-8.4 Automated backport with mergify backport-8.5 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Sep 28, 2022
@dedemorton dedemorton requested a review from a team September 28, 2022 21:58
@dedemorton dedemorton added Team:Fleet Label for the Fleet team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Sep 28, 2022
@cmacknz
Copy link
Member

cmacknz commented Sep 28, 2022

Do we include Fleet server changes in these notes as well? There are a few changes there we could include. This is the commit for BC2: https://github.com/elastic/fleet-server/commits/58b61b4f7db6e4e90749cd52755680ec233d02a5

This is the only notable change, which includes a changelog we could add here: elastic/fleet-server@3afc7b5

jen-huang
jen-huang approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto to check what @cmacknz mentioned, otherwise no notes from Fleet side.

@dedemorton @cmacknz
Apply suggestions from code review
ef6f54f 
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
@dedemorton
Copy link
Contributor Author

Do we include Fleet server changes in these notes as well?

@cmacknz We don't at the moment because I was never asked to add this changelong and didn't know it existed. I think we should cover Fleet Server. To avoid confusion with existing release notes, I will just add it to the Fleet section for now, but we should consider having a separate section for Fleet Server in the future.

One thing, though, this changelog message doesn't seem very user friendly:

"LoadServerLimits will not overwrite specified limits when loading default/agent number specified values."

Can we say this instead?

"Fleet Server no longer silently discards user-specified values for cache and server limits when defaults are loaded."

I'm not sure if I have all the technical details correct here. But you can see that passive voice makes the sentence ambiguous, and talking about code internals will probably be confusing to end users (the audience for the release notes).

We should focus on how this fix affects users. Again, I might be misunderstanding something here.... If my suggestion isn't correct, can you help me craft a better changelog entry?

@cmacknz
Copy link
Member

cmacknz commented Sep 29, 2022

"Fleet Server no longer silently discards user-specified values for cache and server limits when defaults are loaded."

This is much clearer than the previous changelog entry, thanks!

@dedemorton dedemorton merged commit 4d69c3a into elastic:main Sep 29, 2022
@dedemorton dedemorton deleted the add_8-4-3_relnotes branch September 29, 2022 23:37
@mergify mergify bot mentioned this pull request Sep 29, 2022
Merged
mergify bot pushed a commit that referenced this pull request Sep 29, 2022
@dedemorton @mergify
Adds Fleet/Agent 8.4.3 release notes (#2201)
c59aa18 
* Adds Fleet/Agent 8.4.3 release notes

* Add Elastic Agent items to release notes

* Apply suggestions from code review

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Add Fleet Server bug fix

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
(cherry picked from commit 4d69c3a)
dedemorton added a commit that referenced this pull request Sep 30, 2022
@mergify @dedemorton
Adds Fleet/Agent 8.4.3 release notes (#2201) (#2211)
7cf3a8c 
* Adds Fleet/Agent 8.4.3 release notes

* Add Elastic Agent items to release notes

* Apply suggestions from code review

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Add Fleet Server bug fix

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
(cherry picked from commit 4d69c3a)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@dedemorton
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2022

update

☑️ Nothing to do

  • #commits-behind>0 [:pushpin: update requirement]
  • -closed [:pushpin: update requirement]

@mergify mergify bot mentioned this pull request Sep 30, 2022
Merged
mergify bot pushed a commit that referenced this pull request Sep 30, 2022
@dedemorton @mergify
Adds Fleet/Agent 8.4.3 release notes (#2201)
ecdfe13 
* Adds Fleet/Agent 8.4.3 release notes

* Add Elastic Agent items to release notes

* Apply suggestions from code review

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Add Fleet Server bug fix

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
(cherry picked from commit 4d69c3a)
dedemorton added a commit that referenced this pull request Sep 30, 2022
@mergify @dedemorton
Adds Fleet/Agent 8.4.3 release notes (#2201) (#2212)
f52f942 
* Adds Fleet/Agent 8.4.3 release notes

* Add Elastic Agent items to release notes

* Apply suggestions from code review

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Add Fleet Server bug fix

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
(cherry picked from commit 4d69c3a)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
@dedemorton @cmacknz
Adds Fleet/Agent 8.4.3 release notes (elastic#2201)
965ad4c 
* Adds Fleet/Agent 8.4.3 release notes

* Add Elastic Agent items to release notes

* Apply suggestions from code review

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Add Fleet Server bug fix

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang approved these changes

@cmacknz cmacknz cmacknz approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse was automatically assigned from elastic/elastic-agent-control-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman was automatically assigned from elastic/elastic-agent-control-plane

Assignees

@dedemorton dedemorton

Labels
backport-8.4 Automated backport with mergify backport-8.5 Automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Fleet Label for the Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dedemorton @apmmachine @cmacknz @jen-huang