Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details for logging.metrics.enabled #853

Merged
merged 4 commits into from
Aug 13, 2021

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented Jul 12, 2021

Add details for how logging.metrics.enabled is used by the agent and underlying beats.

@michel-laterman michel-laterman added Team:Elastic-Agent Label for the Agent team v7.15.0 labels Jul 12, 2021
@michel-laterman michel-laterman requested a review from a team as a code owner July 12, 2021 18:07
@apmmachine
Copy link
Contributor

apmmachine commented Jul 12, 2021

A documentation preview will be available soon:

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Just a couple of minor changes.

…ation.asciidoc

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@michel-laterman michel-laterman changed the title Add doc for agent.monitoring.log_metrics Add details for logging.metrics.enabled Aug 12, 2021
@michel-laterman
Copy link
Contributor Author

@dedemorton, we have decided to reuse an existing configuration value for this task; i've adjusted the pr to reflect this.

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor comments. otherwise LGTM.

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@michel-laterman michel-laterman merged commit ee208b0 into elastic:master Aug 13, 2021
@michel-laterman michel-laterman deleted the log-metrics-doc branch August 13, 2021 16:28
michel-laterman added a commit to michel-laterman/observability-docs that referenced this pull request Aug 13, 2021
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
* Add details for logging.metrics.enabled

* Apply suggestions from code review

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants