Remove removable flag from package manifest

[ruflin]

Based on the discussion in #455 it is not up to the package to decide which packages can be removed but Kibana. Because of this, the removable flag is removed from the registry and the packages.

Closing #455

[ruflin]

This PR should only be merged if changes made it into Kibana. @paul-tavares Could you ping us here when this happened?

[elasticmachine]

💚 Build Succeeded

Expand to view the summary

Build stats

• Build Cause: [Branch indexing]

• Start Time: 2020-06-25T12:18:32.146+0000

• Duration: 8 min 32 sec

Test stats 🧪

Test	Results
Failed	0
Passed	143
Skipped	0
Total	143

[mtojek]

Did you check if the flag is used in the integrations repository?

[ruflin]

@mtojek It is for the system package. Al others are set to true (the default): https://github.com/elastic/integrations/blob/0ae2f28fa667952f1b8c682ebec4163bbfe3bef6/dev/import-beats/packages.go#L26 I'll follow up on the integrations repo as soon as we get this in, but first work must happen in Kibana.

[jfsiii]

elastic/kibana#69761 is ready but without #204 & the corresponding Kibana change we can't push changes independently

[ruflin]

@jfsiii Not sure I follow why elastic/kibana#69761 can't be merged as it only removes a field and I assume if the registry still ships it, it should not affect the Kibana?

If we would use the versioned API for every breaking change we do at the moment, we would already be at v25. This will of course change when we hit 7.9.

[jfsiii]

@ruflin You're right elastic/kibana#69761 can go in before this change, just not the other way around. I'll merge that PR now

If we would use the versioned API for every breaking change we do at the moment, we would already be at v25.

Having a strategy doesn't mean we need to use that strategy but we can discuss that in the relevant issue

[ruflin]

@jfsiii I kicked off #560 related to the above.

[ruflin]

Merging as elastic/kibana#69906 is merged.