-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include metric types in tsdb index and template mappings #316
Merged
salvatore-campagna
merged 7 commits into
elastic:master
from
salvatore-campagna:feature/tsdb-time-series-metrics-definition
Sep 8, 2022
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d39c641
tsdb: extract index mappings and include metric type
salvatore-campagna 7480220
tsdb: include a new downsampling challenge
salvatore-campagna dc2d05c
fix: use the correct index
salvatore-campagna 6a2166d
test: add date aggregations to append-no-conflicts challenge
salvatore-campagna 6b1456f
fix: date aggregation on the right index
salvatore-campagna a125ed5
fix: use 'downsample' instead of 'downsampling'
salvatore-campagna 581a3f9
fix: get rid of the body parameter
salvatore-campagna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if it makes sense to have these three aggregations here or if we want to just have them under an "aggs" challenge for the tsdb track (not part of the downsampling challenge). Maybe we can keep them until we have an "aggs" challenge for the tsdb track?