-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include a new downsampling operation #1574
Merged
salvatore-campagna
merged 28 commits into
elastic:master
from
salvatore-campagna:feature/downsampling-operation
Sep 19, 2022
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
1f4e757
feature: include a new downsampling operation
salvatore-campagna 126e99c
fix: documentation format violations
salvatore-campagna 54b9829
fix: documentation format violations
salvatore-campagna 61ade59
fix: use f-string for path
salvatore-campagna edf2e08
fix: use 'downsample'
salvatore-campagna 81db5c6
fix: use 'downsample' instead of 'downsampling'
salvatore-campagna 1446d12
fix: get rid of the body parameter
salvatore-campagna b81526d
fix: make Downsample operation administrative
salvatore-campagna 433726c
fix: remove body parameter
salvatore-campagna 97e2922
fix: make Downsample non-administrative
salvatore-campagna e4a8d81
fix: remove body parameter
salvatore-campagna d813ce0
test: fix endpoint and do not require body
salvatore-campagna 01d0d75
Update docs/track.rst
salvatore-campagna 571b712
Update docs/track.rst
salvatore-campagna aaac8c5
Update docs/track.rst
salvatore-campagna 2424935
Update docs/track.rst
salvatore-campagna 1f3ed4b
fix: include a param source for the downsample operation
salvatore-campagna 693a9d3
fix: do not fail if index does not exist
salvatore-campagna 476a573
Merge branch 'master' into feature/downsampling-operation
salvatore-campagna d5e5ffe
fix: use get_target instead of static default value
salvatore-campagna 9d1c257
fix: remove ignore_unavailable param
salvatore-campagna cad9f53
fix: params.get_target attribute does not exist
salvatore-campagna 7e063e2
test: use index instead of source-index
salvatore-campagna ad1a9a6
fix: support both index and source-index params
salvatore-campagna 104a715
fix: explicitly check the default fixed_interval
salvatore-campagna 21cc596
test: check both default index and source index
salvatore-campagna 029babb
docs: update source-index param documentation
salvatore-campagna 86e05ee
fix: do not assert source-index
salvatore-campagna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this test buys us? Checked with a debugger and captured the value of p:
Might be better instead to have the Track constructor call include an
indices
param with value like[{"name": "test-source-index", "body": "index.json"}]
and assert that source-index gets provided astest-source-index