Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude telemetry devices based on serverless status #1770

Merged
merged 7 commits into from
Aug 31, 2023

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Aug 25, 2023

Can be tested using:

esrally race --track-path=$HOME/src/rally-tracks/geonames --test-mode --target-hosts=... --pipeline=benchmark-only --client-options=serverless.json --on-error=abort --telemetry=ccr-stats

This will run the race and print:

[INFO] Excluding telemetry device [ccr-stats] as it is unavailable on serverless.                                                         

To test without operator status, you should either include #1768 or set serverless.operator to false in the rally.ini [driver] section.

TODO:

  • Tests
  • Figure out why the message is printed twice

@pquentin pquentin added the enhancement Improves the status quo label Aug 25, 2023
@pquentin pquentin added this to the 2.10.0 milestone Aug 25, 2023
@pquentin pquentin self-assigned this Aug 25, 2023
@pquentin
Copy link
Member Author

To be clear, here is the current output:

[INFO] Race id is [de8d87c7-26d2-4caa-a8b6-5747281babb1]                                                                                                       
[INFO] Treating parallel task in challenge [indexing-querying] as public.                                                                                      
[INFO] Excluding [put-settings], [check-cluster-health], [force-merge], [wait-until-merges-finish] as challenge [indexing-querying] is run on serverless.      
[INFO] Racing on track [pmc], challenge [indexing-querying] and car ['external'] with version [8.10.0].                                                        
                                                                                                                
[INFO] Excluding telemetry device [ccr-stats] as it is unavailable on serverless.       
Running delete-index                                                           [100% done]
Running create-index                                                           [100% done]
Running initial-index-append                                                   [100% done]
Running refresh-after-index                                                    [100% done]
Running refresh-after-force-merge                                              [100% done]
Running phrase,articles_monthly_agg_uncached,default,term,articles_mont...     [100% done]
[INFO] Excluding telemetry device [ccr-stats] as it is unavailable on serverless.       

The empty line between "Racing" and "Excluding" is annoying, but I want to remove the second "Excluding" message between the "Running" messages and the summary report.

esrally/telemetry.py Outdated Show resolved Hide resolved
@pquentin
Copy link
Member Author

OK, it should be correct now! A nice win for test-driven development. Please take another look.

@pquentin pquentin requested a review from b-deam August 30, 2023 11:16
Copy link
Member

@b-deam b-deam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@pquentin pquentin merged commit 3398bb8 into elastic:master Aug 31, 2023
14 checks passed
@pquentin pquentin deleted the exclude-telemetry-devices branch August 31, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants