Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverless-aware runners #1789

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Conversation

gbanasiak
Copy link
Contributor

@gbanasiak gbanasiak commented Oct 6, 2023

This PR passes configuration context to Query, DeleteIndex and DeleteComposableTemplate runners to make them serverless-aware and change their behaviour if Rally targets serverless cluster.

Changes:

  • Query, DeleteIndex and DeleteComposableTemplate stop getting and setting cluster settings through set_destructive_requires_name() as cluster settings are not available to serverless users. In case of DeleteIndex this replaces the earlier crude workaround through contextlib.suppress introduced in Fix serverless public use in trivial tracks #1785.
  • The DeleteComposableTemplate runner starts to ignore delete_matching_indices template option. Wildcard deletes are not available to serverless users (!). DeleteIndexTemplate runner is not fixed as legacy templates are not available in serverless.
  • Request cache becomes turned on by default for serverless non-operator use in the Query runner (search, paginated-search, composite-agg and scroll-search operations). In non-serverless use we typically rely on "index.requests.cache.enable": false index setting for this purpose but it is not available to serverless users. As part of this change I've removed request params in /_search/scroll which is present in certain Query scenarios, as /_search/scroll does not accept request_cache parameter and it is the only parameter used.

@gbanasiak gbanasiak added this to the 2.10.0 milestone Oct 6, 2023
@gbanasiak gbanasiak requested a review from a team October 6, 2023 11:25
@gbanasiak gbanasiak marked this pull request as ready for review October 6, 2023 11:25
esrally/driver/runner.py Outdated Show resolved Hide resolved
@b-deam b-deam added enhancement Improves the status quo :Usability Makes Rally easier to use :Track Management New operations, changes in the track format, track download changes and the like :Docs Changes to the documentation labels Oct 16, 2023
@gbanasiak gbanasiak merged commit aba239a into elastic:master Oct 16, 2023
15 checks passed
@gbanasiak gbanasiak deleted the config-aware-runners branch October 16, 2023 08:13
@gbanasiak gbanasiak removed the :Docs Changes to the documentation label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like :Usability Makes Rally easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants