Avoid immense term error in metrics metadata fields #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gareth-ellis
reviewed
Mar 4, 2024
inqueue
approved these changes
Mar 12, 2024
| "meta": { | ||
| "properties": { | ||
| "error-description": { | ||
| "type": "wildcard" |
There was a problem hiding this comment.
The wildcard mapping type is a wise choice for our use case. error-description can be quite large and does not need the tokenization a text mapping type would bring.
gareth-ellis
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid immense term error in metrics metadata fields:
meta.error-descriptionfield mapping changes fromkeywordtowildcardwhich fits this type of content better while still allowing the search,"ignore_above": 8191parameter to prevent immense term error in the worst case of error message being composed entirely of UTF-8 characters (see doc),meta.error-descriptionfield generated inBulkIndexrunner gets limited to 5 unique errors only for better log readability - currently, in the worst case the field is concatenated from errors from all bulk documents.Addresses #1834.