Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume no operator if security not enabled in serverless #1851

Merged
merged 3 commits into from
May 29, 2024

Conversation

gbanasiak
Copy link
Contributor

When testing locally serverless might be running without security enabled. In this case, GET _security/_authenticate fails. This PR falls back to non-operator privileges in such case.

@gbanasiak gbanasiak added this to the 2.11.0 milestone May 29, 2024
esrally/client/factory.py Outdated Show resolved Hide resolved
Copy link
Member

@gareth-ellis gareth-ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

esrally/client/factory.py Outdated Show resolved Hide resolved
gbanasiak and others added 2 commits May 29, 2024 15:00
Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@gbanasiak gbanasiak merged commit 6706bec into elastic:master May 29, 2024
17 checks passed
@gbanasiak gbanasiak deleted the serverless-security-fallback branch May 29, 2024 14:52
@gareth-ellis gareth-ellis added the enhancement Improves the status quo label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants