Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] New rule fields for prerequisites: Related Integrations, Required Fields, and Setup #2069

Merged
merged 34 commits into from
Aug 25, 2022

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Jun 13, 2022

Addresses #2015.

Previews:

Joe's Li'l Checklist

@joepeeples
Copy link
Contributor Author

joepeeples commented Jun 28, 2022

This feature has been held back from the 8.3.0 release, but keeping the v8.3.0 label for now in case the feature becomes available soon after the release.

@joepeeples joepeeples changed the title [DOCS] New Rule fields: Related Integrations, Required Fields, and Setup [DOCS] New Rule fields: Related Integrations, Required Fields, and Setup - WIP Jun 29, 2022
@joepeeples joepeeples changed the title [DOCS] New Rule fields: Related Integrations, Required Fields, and Setup - WIP [DOCS] [WIP] New Rule fields: Related Integrations, Required Fields, and Setup Jun 29, 2022
@mergify

This comment was marked as resolved.

@joepeeples joepeeples removed the readyforQA PRs that are ready for QA review. label Aug 22, 2022
@mergify

This comment was marked as resolved.

@mergify

This comment was marked as resolved.

docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
Comment on lines 183 to 184
* Adds new fields to prebuilt detection rules' schemas: `related_integrations`, `required_fields`, and `setup` ({pull}132409[#132409]).
* Adds *Related integrations*, *Required fields*, and *Setup guide* sections to the rule details page, to help users identify, install, and configure a rule's prerequisites. Also adds related integrations badge to the rules table ({pull}131475[#131475]). Content for these new sections is delivered in a prebuilt rules update, independent of {stack} release versioning.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to update the 8.3 release notes? Am I understanding correctly that we'll do it only if rules with those fields will be released in one of the 8.3.x Out-Of-Band updates for the Prebuilt Detection Rules package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@banderror Yes, this section will update the 8.3 release notes (the file name is version-specific).

For 8.4 release notes, we have a separate PR that's currently in progress, though it doesn't yet mention the new fields because they're not yet available in the UI. Once I can confirm that, I'll add the same wording from above to those 8.4 notes.

Basically before we merge anything related to the new fields, I'm waiting to confirm that the latest prebuilt rules package has been published and the new fields are available in both 8.3.x and 8.4.0.

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor edits. LGTM otherwise!

docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/release-notes/8.3.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 👍

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left two minor suggestions

[role="screenshot"]
image::images/rules-table-related-integrations.png[Rules table with related integrations popup,75%]

TIP: You can hide the related integrations badge in the Rules tables. Go to *{kib}* -> *Stack Management* -> *Advanced Settings*, then turn off `securitySolution:showRelatedIntegrations`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe do "related integrations" with a capital at the beginning, or in code text

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just "integrations" to match the UI text, and bold because it's a UI label the user clicks, not text they enter.

I'll change this in a separate comment, so I can include the reference to the badge in line 97 above too.

[[show-related-integrations]]
== Show/hide related integrations in Rules page tables

By default, Elastic prebuilt rules in the *Rules* and *Rule Monitoring* tables include a badge showing how many related integrations have been installed. Turn off `securitySolution:showRelatedIntegrations` to hide this in the rules tables (related integrations will still appear on rule details pages).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe link to advanced settings here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benironside This text is already on the advanced settings page. Do you mean add a link somewhere else that points TO this section?

@joepeeples joepeeples merged commit 953f781 into main Aug 25, 2022
mergify bot pushed a commit that referenced this pull request Aug 25, 2022
…red Fields, and Setup (#2069)

* Add new section to Advanced Settings

* Update page's mini-TOC

* Re-adds RNs for 132409 and 131475

* Revise advanced setting description

* Create new section for related integrations etc.

Includes placeholder image syntax, commented out

* Add fields to API response examples

* Update release notes

* Add new section to What's New

Includes placeholder image syntax, commented out

* Additional revisions

* Complete main documentation

Add and update screenshots
Revise explanatory text

* Update release notes and What's New

* Revert changes to whats-new.asciidoc

What's new 8.3 will be updated in PR security-docs#2327

* Update per new nav UI

* Apply suggestions from Nastasha's review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Apply suggestions from Ben's review

* Update docs/release-notes/8.3.asciidoc

Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 953f781)
mergify bot pushed a commit that referenced this pull request Aug 25, 2022
…red Fields, and Setup (#2069)

* Add new section to Advanced Settings

* Update page's mini-TOC

* Re-adds RNs for 132409 and 131475

* Revise advanced setting description

* Create new section for related integrations etc.

Includes placeholder image syntax, commented out

* Add fields to API response examples

* Update release notes

* Add new section to What's New

Includes placeholder image syntax, commented out

* Additional revisions

* Complete main documentation

Add and update screenshots
Revise explanatory text

* Update release notes and What's New

* Revert changes to whats-new.asciidoc

What's new 8.3 will be updated in PR security-docs#2327

* Update per new nav UI

* Apply suggestions from Nastasha's review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Apply suggestions from Ben's review

* Update docs/release-notes/8.3.asciidoc

Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 953f781)

# Conflicts:
#	docs/detections/api/rules/rules-api-bulk-actions.asciidoc
#	docs/detections/images/all-rules.png
#	docs/detections/images/monitor-table.png
joepeeples added a commit that referenced this pull request Aug 25, 2022
…red Fields, and Setup (#2069) (#2385)

* Add new section to Advanced Settings

* Update page's mini-TOC

* Re-adds RNs for 132409 and 131475

* Revise advanced setting description

* Create new section for related integrations etc.

Includes placeholder image syntax, commented out

* Add fields to API response examples

* Update release notes

* Add new section to What's New

Includes placeholder image syntax, commented out

* Additional revisions

* Complete main documentation

Add and update screenshots
Revise explanatory text

* Update release notes and What's New

* Revert changes to whats-new.asciidoc

What's new 8.3 will be updated in PR security-docs#2327

* Update per new nav UI

* Apply suggestions from Nastasha's review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Apply suggestions from Ben's review

* Update docs/release-notes/8.3.asciidoc

Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 953f781)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
joepeeples added a commit that referenced this pull request Aug 25, 2022
… Required Fields, and Setup (backport #2069) (#2386)

* [DOCS] New rule fields for prerequisites: Related Integrations, Required Fields, and Setup (#2069)

* Add new section to Advanced Settings

* Update page's mini-TOC

* Re-adds RNs for 132409 and 131475

* Revise advanced setting description

* Create new section for related integrations etc.

Includes placeholder image syntax, commented out

* Add fields to API response examples

* Update release notes

* Add new section to What's New

Includes placeholder image syntax, commented out

* Additional revisions

* Complete main documentation

Add and update screenshots
Revise explanatory text

* Update release notes and What's New

* Revert changes to whats-new.asciidoc

What's new 8.3 will be updated in PR security-docs#2327

* Update per new nav UI

* Apply suggestions from Nastasha's review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Apply suggestions from Ben's review

* Update docs/release-notes/8.3.asciidoc

Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 953f781)

# Conflicts:
#	docs/detections/api/rules/rules-api-bulk-actions.asciidoc
#	docs/detections/images/all-rules.png
#	docs/detections/images/monitor-table.png

* Remove dry run example from 8.4

Hopefully this resolves merge conflict

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@joepeeples joepeeples deleted the issue-2015-related-int-required-fields-setup branch August 25, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants