Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Attack surface reduction / credential hardening #2266

Merged
merged 6 commits into from
Aug 18, 2022
Merged

[DOCS] Attack surface reduction / credential hardening #2266

merged 6 commits into from
Aug 18, 2022

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Aug 5, 2022 •
edited
Loading

Resolves #2235.

Preview: Configure an integration policy for Endpoint and Cloud Security | Attack surface reduction

Questions for reviewers:

  • Less/more detail about LSASS, or any other inner workings?
  • Any licensing requirements?

@joepeeples joepeeples added Team: Docs Team: Endpoint Endpoint related issues Feature: Policy Elastic Defend integration policy and configuration v8.4.0 labels Aug 5, 2022
@joepeeples joepeeples self-assigned this Aug 5, 2022
@joepeeples joepeeples marked this pull request as ready for review August 8, 2022 13:33
ferullo
ferullo reviewed Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@ferullo ferullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magermark do you have thoughts on this doc?

@magermark
Copy link

Descriptions of attack surface reduction and credential hardening look great to me!

jmikell821
jmikell821 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This language was a little over my head 😆 but structure/grammar LGTM!

nastasha-solomon
nastasha-solomon approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super tiny rec and one comment - otherwise, LGTM!

docs/getting-started/configure-integration-policy.asciidoc Outdated Show resolved Hide resolved
@joepeeples @nastasha-solomon
Apply suggestions from Nastasha's review
f17f41c 
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
@joepeeples joepeeples added the readyforQA PRs that are ready for QA review. label Aug 16, 2022
@muskangulati-qasource
Copy link

Hi @nastasha-solomon,

We have reviewed the shared preview links and observed that everything is written as per functionality 🟢

Screenshots:
image
image

Hence we are adding the "QA: Validated" label to it.

Thanks!!

@muskangulati-qasource muskangulati-qasource added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Aug 17, 2022
@ferullo ferullo mentioned this pull request Aug 18, 2022
Closed
@joepeeples joepeeples mentioned this pull request Aug 18, 2022
Closed
20 tasks
@joepeeples joepeeples merged commit 035c975 into main Aug 18, 2022
mergify bot pushed a commit that referenced this pull request Aug 18, 2022
@joepeeples @mergify
[DOCS] Attack surface reduction / credential hardening (#2266)
5957d47 
* First draft and screenshot

* Add to page jump list, minor edit

* Smol edit

* Apply suggestions from Nastasha's review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 035c975)
@mergify mergify bot mentioned this pull request Aug 18, 2022
Merged
@joepeeples joepeeples deleted the issue-2235-credential-protection branch August 18, 2022 20:01
nastasha-solomon pushed a commit to nastasha-solomon/security-docs that referenced this pull request Sep 19, 2022
@mergify @joepeeples
[DOCS] Attack surface reduction / credential hardening (elastic#2266) (…
d83d4a2 
…elastic#2325)

* First draft and screenshot

* Add to page jump list, minor edit

* Smol edit

* Apply suggestions from Nastasha's review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 035c975)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferullo ferullo ferullo left review comments

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@magermark magermark magermark approved these changes

@jmikell821 jmikell821 jmikell821 approved these changes

@benironside benironside benironside approved these changes

@roxana-gheorghe roxana-gheorghe roxana-gheorghe approved these changes

Assignees

@joepeeples joepeeples

Labels
Feature: Policy Elastic Defend integration policy and configuration QA:Validated Issue has been Validated by QA Team Team: Docs Team: Endpoint Endpoint related issues v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Attack surface reduction / credential hardening
8 participants
@joepeeples @magermark @muskangulati-qasource @ferullo @jmikell821 @nastasha-solomon @benironside @roxana-gheorghe