Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualizations & Lens embeddables being added throughout Security app #3298

Merged
merged 4 commits into from
May 22, 2023
Merged

Visualizations & Lens embeddables being added throughout Security app #3298

merged 4 commits into from
May 22, 2023

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented May 17, 2023 •
edited
Loading

Resolves #2954.

Previews:

@joepeeples joepeeples added Team: Threat Hunting Formerly Data Visibility v8.8.0 labels May 17, 2023
@joepeeples joepeeples self-assigned this May 17, 2023
@github-actions
Copy link

Documentation previews:

@joepeeples joepeeples marked this pull request as ready for review May 18, 2023 16:10
benironside
benironside reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few minor suggestions for your consideration

docs/dashboards/overview-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-visualizations.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/security-ui.asciidoc Outdated Show resolved Hide resolved
nastasha-solomon
nastasha-solomon approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two minor suggestions. LGTM otherwise!

docs/dashboards/overview-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/security-ui.asciidoc Outdated Show resolved Hide resolved
angorayc
angorayc approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating them!

jmikell821
jmikell821 reviewed May 22, 2023
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one ponderism. Other than that, LGTM!

docs/getting-started/security-ui.asciidoc Show resolved Hide resolved
docs/detections/alerts-visualizations.asciidoc Show resolved Hide resolved
@joepeeples joepeeples merged commit 32f106b into main May 22, 2023
mergify bot pushed a commit that referenced this pull request May 22, 2023
@joepeeples @mergify
Visualizations & Lens embeddables being added throughout Security app (…
1bf79f6 
…#3298)

* First draft

* More edits

* Apply suggestions from code review

(cherry picked from commit 32f106b)
@mergify mergify bot mentioned this pull request May 22, 2023
Merged
@joepeeples joepeeples deleted the 2954-lens-embeddables branch May 22, 2023 22:29
joepeeples added a commit that referenced this pull request May 22, 2023
@mergify @joepeeples
Visualizations & Lens embeddables being added throughout Security app (…
5993076 
…#3298) (#3331)

* First draft

* More edits

* Apply suggestions from code review

(cherry picked from commit 32f106b)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@joepeeples joepeeples mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikell821 jmikell821 jmikell821 left review comments

@benironside benironside benironside left review comments

@angorayc angorayc angorayc approved these changes

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

Assignees

@joepeeples joepeeples

Labels
Team: Threat Hunting Formerly Data Visibility v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visualizations & Lens embeddables being added throughout Security app
5 participants
@joepeeples @angorayc @jmikell821 @nastasha-solomon @benironside