Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update Docker Compose setup #1906

Merged

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Dec 6, 2021

Updates the procedure and files for Starting the Stack with Docker Compose.

  • Removes extraneous files
  • Implements streamlined and more capable Docker Compose file
  • Updates surrounding text to align with changes

Preview link: https://stack-docs_1906.docs-preview.app.elstc.co/guide/en/elastic-stack-get-started/master/get-started-stack-docker.html#get-started-docker-tls

Closes elastic/elasticsearch#81133

Apply these changes to the Elasticsearch installation docs

After we merge this PR, we should update the section for starting a multi-node cluster with Docker Compose in the installation docs. Issue #81786 tracks this needed change.

@lockewritesdocs
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Contributor

@bytebilly bytebilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lockewritesdocs thanks for putting this together! I did a first pass with some suggested change, let me know what you think.

docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Fabio Busatto <52658645+bytebilly@users.noreply.github.com>
@lockewritesdocs
Copy link
Contributor Author

@bytebilly, we can backport this change to 7.x, correct?

@bytebilly
Copy link
Contributor

@bytebilly, we can backport this change to 7.x, correct?

We can probably update the 7.16-7.17 documentation with the same content (after testing). I cannot guarantee that this could work with any 7.x older release, and I don't think that it has great benefits to go through all of them.

@bytebilly
Copy link
Contributor

@lockewritesdocs is it possible to get the preview docs for the updated version? Thanks!

@lockewritesdocs
Copy link
Contributor Author

Copy link
Contributor

@bytebilly bytebilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lockewritesdocs that's awesome! I left a few final comments for you to review.

docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
@lockewritesdocs lockewritesdocs merged commit c550028 into elastic:main Dec 16, 2021
@lockewritesdocs lockewritesdocs deleted the docs__update-docker-compose branch December 16, 2021 19:38
lockewritesdocs pushed a commit to lockewritesdocs/stack-docs that referenced this pull request Dec 16, 2021
* [DOCS] Update Docker Compose setup

* Update remove instructions and rename section ids

* Remove cross-links, which won't display and cause errors for unreleased versions

* Incorporate feedback from Fabio

Co-authored-by: Fabio Busatto <52658645+bytebilly@users.noreply.github.com>

* Clarifications and adding Docker Compose link

* Remove directory name

* Update container names and config file snippets

* Fix typo

* Incorporating final changes

* Update note on exposing ports

* Updating .env and docker-compose.yml files

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Fabio Busatto <52658645+bytebilly@users.noreply.github.com>
lockewritesdocs pushed a commit that referenced this pull request Dec 17, 2021
* [DOCS] Update Docker Compose setup

* Update remove instructions and rename section ids

* Remove cross-links, which won't display and cause errors for unreleased versions

* Incorporate feedback from Fabio

Co-authored-by: Fabio Busatto <52658645+bytebilly@users.noreply.github.com>

* Clarifications and adding Docker Compose link

* Remove directory name

* Update container names and config file snippets

* Fix typo

* Incorporating final changes

* Update note on exposing ports

* Updating .env and docker-compose.yml files

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Fabio Busatto <52658645+bytebilly@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Fabio Busatto <52658645+bytebilly@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Replace Docker Compose files and setup
3 participants