[DOCS] Consolidates ELSER deployment guide with ES deployment tutorial content #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
szabosteve
added
:ml
WIP
There was a problem hiding this comment.
@szabosteve These changes look great.
I suggested a few changes inline. There are also two instances where the Kibana breadcrumb needs to be updated. The breadcrumb used to be "Enterprise Search > Indices", but now it is "Search > Indices". I forgot to call this out in the requirements.
I didn't spot any other instances of "Enterprise Search" in the doc, but in general we want to get rid of any mentions of Enterprise Search and instead present this as a feature specific to Elasticsearch and Kibana.
|
@chriscressman Thank you for your thoughtful review; I updated the breadcrumbs and addressed your comments via f02d5ee. |
leemthompo
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related to https://github.com/elastic/platform-docs-team/issues/237 and https://github.com/elastic/enterprise-search-team/issues/5901.
This PR adds the majority of the ELSER-related deployment content from the Enterprise Search book to the ELSER conceptual docs, it also adds a new section to the page called
Performance considerationsthat copies the relevant information to the page from theLimitations and notessection of the ES page.Preview
ELSER ES