Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds adaptive allocations feature description to conceptual docs #2763

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Aug 1, 2024

Overview

This PR describes adaptive allocations in the ml-nlp-shared.asciidoc file. The feature description is then single-sourced from there in the ELSER, E5, and deploy trained model conceptual docs.

Preview

Copy link

github-actions bot commented Aug 1, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@szabosteve szabosteve marked this pull request as ready for review August 1, 2024 10:30
@szabosteve szabosteve requested a review from a team as a code owner August 1, 2024 10:30
Copy link

@jan-elastic jan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of small things. in general lgtm

@szabosteve
Copy link
Contributor Author

@jan-elastic Thanks for your review, I addressed your comments via 1de8986.

Copy link

@jan-elastic jan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szabosteve szabosteve merged commit 506ba9c into elastic:main Aug 1, 2024
3 checks passed
@szabosteve szabosteve deleted the adaptive-allocation branch August 1, 2024 14:23
mergify bot pushed a commit that referenced this pull request Aug 1, 2024
* Adds adaptive allocations feature description to conceptual docs.

* Fixes typo.

* Fine-tunes text.

* Adds reference to adaptive allocations to the allocation description.

* [DOCS] Addresses feedback.

(cherry picked from commit 506ba9c)
szabosteve added a commit that referenced this pull request Aug 1, 2024
…) (#2764)

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants