Add Kibana application privileges to the reserved role docs #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users who create roles that are similar to the reserved roles need to know about these. The privileges were added to the reserved roles in elastic/elasticsearch#40651 and elastic/elasticsearch#42757
kobelb
approved these changes
May 31, 2019
lcawl
reviewed
May 31, 2019
| @@ -39,11 +39,13 @@ suitable for writing beats output to {es}. | |||
|
|
|||
| [[built-in-roles-data-frame-transforms-admin]] `data_frame_transforms_admin` :: | |||
| Grants `manage_data_frame_transforms` cluster privileges, which enable you to | |||
| manage data frames. | |||
| manage data frame transforms. This role also includes the `reserved_ml` {kib} | |||
There was a problem hiding this comment.
@kobelb will this level of Kibana privilege be documented anywhere? It doesn't seem we go into that level of detail in https://www.elastic.co/guide/en/kibana/master/kibana-privileges.html so maybe we should omit it here too? e.g. Change it to something like "Users with this role have all {ml} feature privileges in Kibana".
There was a problem hiding this comment.
That's a good point... we've generally hidden the concept of "Kibana reserved privileges" from end-users, so the phrasing which you've recommended might make this less confusing to users.
There was a problem hiding this comment.
Thanks @kobelb ! @droberts195 I've drafted suggestions for the changes.
lcawl
reviewed
May 31, 2019
lcawl
reviewed
May 31, 2019
lcawl
reviewed
May 31, 2019
lcawl
reviewed
May 31, 2019
lcawl
reviewed
May 31, 2019
lcawl
reviewed
May 31, 2019
lcawl
reviewed
May 31, 2019
lcawl
reviewed
May 31, 2019
lcawl
reviewed
May 31, 2019
lcawl
reviewed
May 31, 2019
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
droberts195
added a commit
that referenced
this pull request
Jun 5, 2019
Users who create roles that are similar to the reserved roles need to know about these. The privileges were added to the reserved roles in elastic/elasticsearch#40651 and elastic/elasticsearch#42757 Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
droberts195
added a commit
that referenced
this pull request
Jun 5, 2019
Users who create roles that are similar to the reserved roles need to know about these. The privileges were added to the reserved roles in elastic/elasticsearch#40651 and elastic/elasticsearch#42757 Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users who create roles that are similar to the reserved roles
need to know about these.
The privileges were added to the reserved roles in
elastic/elasticsearch#40651 and elastic/elasticsearch#42757