proxy: return 502 Bad Gateway on round-trip error #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it's not possible to distinguish target server internal error from using a wrong server or server being down. This patch changes status code 500 to 502 in case we cannot get a response from upstream. Below snippets from the HTTP specification: > The HyperText Transfer Protocol (HTTP) 502 Bad Gateway > server error response code indicates that the server, while acting as a gateway or proxy, received an invalid response from the upstream server. https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/502 vs. > The HyperText Transfer Protocol (HTTP) 500 Internal Server Error > server error response code indicates that the server encountered an unexpected condition that prevented it from fulfilling the request. > This error response is a generic "catch-all" response. Usually, this indicates the server cannot find a better 5xx error code to response. Sometimes, server administrators log error responses like the 500 status code with more details about the request to prevent the error from happening again in the future. https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/500 Fixes elazarl#51
This patch allows to distinguish between status codes * 502 - network error, failed to dial * 504 - network error, dial timeout * 500 - other error Relates to elazarl#51
mmatczuk
added a commit
to saucelabs/forwarder
that referenced
this pull request
Nov 8, 2022
My fork is hosting patches I sent upstream to fix issues. It contains patches from * elazarl/goproxy#488 * elazarl/goproxy#489
|
I'm closing this PR, I'd open a new one with a better implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's not possible to distinguish target server internal error from using a wrong server or server being down. This patch changes status code 500 to 502 in case we cannot get a response from upstream.
Below snippets from the HTTP specification:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/502
vs.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/500
Fixes #51