Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Cache the built node #16

Open
rt121212121 opened this issue Aug 11, 2020 · 2 comments
Open

CI: Cache the built node #16

rt121212121 opened this issue Aug 11, 2020 · 2 comments

Comments

@rt121212121
Copy link
Contributor

Now that the node is built using a binaries directory that is decoupled from the source location, we should be able to directly point a Cache task at the BSV build sub-directory and packages should build almost immediately.

The big win is that this then makes rebuilding when there are only Python changes, almost immediate. And it makes making changes to tests, run promptly as well.

@rt121212121 rt121212121 changed the title ci: Cache the built node CI: Cache the built node Aug 11, 2020
@rt121212121
Copy link
Contributor Author

This would likely require:

  • The cache directory being the extracted built objects that the package will include.
  • The build process being changed to move the objects there.
  • The setup.py script using this new cached object directory and skipping the build if it were present, rather than the cloned repo directory.
  • The build scripts taking in an extra argument representing the revision to build (revision is a fixed hash which a tag is not).
  • The cache key using the build revision and OS as part of it for uniqueness.

rt121212121 added a commit that referenced this issue Aug 12, 2020
…of the Bitcoin SV node repo can be skipped.
rt121212121 added a commit that referenced this issue Aug 12, 2020
…ebuilds of the Bitcoin SV node repo can be skipped."

This reverts commit 7aeb47a.
@rt121212121
Copy link
Contributor Author

The plan was flawed. It can't possibly pull in the dependencies unless they are already present, and building Boost is part of the Linux build process this would skip.

@rt121212121 rt121212121 reopened this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant