Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send reaction view quick react and picker #138

Merged
merged 2 commits into from
May 17, 2019

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented May 16, 2019

Fixes #114
Fixes #116

Adding Ability to send reaction via quick react and picker + increment existing

Known Limitations:

  • Can only add reaction (not possible to undo/remove existing)
  • Quick reaction is only adding (e.g. if you disagree a previously agreed event, app will not undo old and add new)
  • Not using the new send_relation API as not available (code created but not tested), uses the regular send event
  • No Optimistic update. Intermediate states e.g. currently sending reaction not handled perfectly (might experience delay) -> Optimistic send in phase 2
  • fix / Error when to many reactions in cells (more than placeholders -8-)
  • fix / DefaultTimeline quick map access was not shifted when items inserted at given index (reaction was added to wrong message)

quick_react

picker_react

increment

+ fix / Error when to many reactions in cells (more than placeholders -8-)
+ fix / DefaultTimeline quick map access was not shifted when items inserted at given index
@BillCarsonFr BillCarsonFr requested review from ganfra and bmarty and removed request for ganfra May 16, 2019 14:50
@BillCarsonFr BillCarsonFr requested a review from ganfra May 16, 2019 16:41
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillCarsonFr BillCarsonFr merged commit 41c5402 into develop May 17, 2019
@bmarty bmarty deleted the feature/send_reaction-phase1 branch July 5, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactions: Increment existing reaction type on click Reactions: Send reaction event when user reacts
2 participants