Feature/fga/message bubbles #4937
Conversation
|
|
||
| abstract fun getViewStubId(): Int | ||
|
|
||
| // Szudzik function |
There was a problem hiding this comment.
Wow, nice to see that here! But is there a risk of overflow since Android ids can be big integers?
There was a problem hiding this comment.
Yeah I changed to Long and then normalize by substracting Int.MAX_VALUE
| * | ||
| * @return true to show emoji keyboard button. | ||
| */ | ||
| fun useMessageBubblesLayout(): Boolean { |
There was a problem hiding this comment.
Please update the comment above :)
|
(Could be nice to add some screenshots in the PR) |
| <im.vector.app.core.preference.VectorSwitchPreference | ||
| android:defaultValue="false" | ||
| android:key="SETTINGS_INTERFACE_BUBBLE_KEY" | ||
| android:title="@string/message_bubbles" /> |
There was a problem hiding this comment.
Better to move this in the timeline section
|
Quick remark, maybe increase the font size of the messages when bubbles are enabled. |
… "modern" layout.
Matrix SDKIntegration Tests Results:
|
|
❌ Error: 'layout_(.*)="@+id' detected 1 time, in file './vector/src/main/res/layout/view_message_bubble.xml', at line 203. Also have you handled all my remarks above? |
There was a problem hiding this comment.
Nice work.
Maybe the changes regarding code block rendering, and URL preview management (with width and heigth) could have been handled in dedicated PR.
Still some small remarks and existing one not yet handle.
After we could merge on develop if the PR is ready!
| private val vectorPreferences: VectorPreferences) { | ||
|
|
||
| companion object { | ||
| // Can't be rendered in bubbles, so get back to default layout |
| private val isRTL: Boolean by lazy { | ||
| val currentLocale = localeProvider.current() | ||
| TextUtils.getLayoutDirectionFromLocale(currentLocale) == View.LAYOUT_DIRECTION_RTL | ||
| } |
There was a problem hiding this comment.
You can do this on develop now: resources.getBoolean(R.bool.is_rtl), simplier to me
There was a problem hiding this comment.
R.bool.is_rtl is not working properly if the user change the language inside the app.
This have to be rework. I create an issue from here :)
There was a problem hiding this comment.
Ah, I'll close the related issue then.
| @@ -76,6 +81,22 @@ class PreviewUrlView @JvmOverloads constructor( | |||
| } | |||
| } | |||
|
|
|||
| override fun render(messageLayout: TimelineMessageLayout) { | |||
There was a problem hiding this comment.
weird to have to render fun in this class now
There was a problem hiding this comment.
Changed to renderMessageLayout
| @@ -55,5 +55,5 @@ | |||
| app:layout_constraintHorizontal_bias="0" | |||
| app:layout_constraintStart_toEndOf="@id/messageThreadSummaryAvatarImageView" | |||
| app:layout_constraintTop_toTopOf="parent" | |||
| tools:text="@sample/messages.json/data/message" /> | |||
| tools:text="Pouet" /> | |||
| @@ -225,7 +223,7 @@ class MessageItemFactory @Inject constructor( | |||
| .locationUrl(locationUrl) | |||
| .mapWidth(width) | |||
| .mapHeight(height) | |||
| .userId(informationData.senderId) | |||
| .userId(userId) | |||
| private val isRTL: Boolean by lazy { | ||
| val currentLocale = localeProvider.current() | ||
| TextUtils.getLayoutDirectionFromLocale(currentLocale) == View.LAYOUT_DIRECTION_RTL | ||
| } |
There was a problem hiding this comment.
Ah, I'll close the related issue then.
This PR introduces message bubbles in Timeline.
It allows to switch Layout at runtime from the Preferences.
It also improves a bit Code Block rendering and Url previews.