Fix | Share room keys with dehydrated devices #8842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
reviewed
Jun 3, 2024
| * Optional property `dehydrated`, which is set to true for dehydrated devices. | ||
| */ | ||
| @Json(name = "dehydrated") | ||
| val dehydrated: Boolean? = null, |
There was a problem hiding this comment.
We should do more than just add the dehydrated flag, or else any other unknown fields that show up in a device will cause the same issue. Is it possible to add a general "unknown fields" property, like is done in Rust? Or can we just pass through the whole device key unparsed, since we end up just re-encoding it and the Rust code re-parses it?
There was a problem hiding this comment.
Updated, now accepting any json payload for deviceKeys. It is not needed any how now (was usefull with legacy crypto, but now all signing and signature checking is done in the olmMachine layer)
bmarty
approved these changes
Jun 6, 2024
uhoreg
approved these changes
Jun 6, 2024
BillCarsonFr
force-pushed
the
feature/bca/send_to_dehydrated_devices
branch
from
4299477
to
ad9f9fb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8836
The dehydrated flag was not parsed and sent to the rust layer, making this device unusable.
Type of change
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist