Skip to content

Commit

Permalink
Set SUID bit on chrome-sandbox for Debian
Browse files Browse the repository at this point in the history
This tweaks Linux packages for Riot to SUID `chrome-sandbox` after install. This
is required as of Electron 5 for certain distros, such as Debian.

This change has also been provided to `electron-builder` upstream, so ideally
they'll include it in the future and this becomes redundant.

Fixes #10509
  • Loading branch information
jryans committed Aug 16, 2019
1 parent 9ed647d commit 56674ea
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
12 changes: 12 additions & 0 deletions electron_app/build/linux/after-install.tpl
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/bin/bash

# Link to the binary
ln -sf '/opt/${productFilename}/${executable}' '/usr/bin/${executable}'

# SUID chrome-sandbox for Electron 5+
# Remove this custom after-install.tpl once this change has been upstreamed
# https://github.com/electron-userland/electron-builder/pull/4163
chmod 4755 '/opt/${productFilename}/chrome-sandbox' || true

update-mime-database /usr/share/mime || true
update-desktop-database /usr/share/applications || true
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@
"StartupWMClass": "riot"
}
},
"deb": {
"afterInstall": "electron_app/build/linux/after-install.tpl"
},
"mac": {
"category": "public.app-category.social-networking"
},
Expand Down

0 comments on commit 56674ea

Please sign in to comment.