Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Electron 6 #10473

Closed
jryans opened this issue Jul 31, 2019 · 2 comments
Closed

Upgrade to Electron 6 #10473

jryans opened this issue Jul 31, 2019 · 2 comments
Assignees
@jryans
Labels
A-Electron P2 T-Defect T-Task Tasks for the team like planning Z-Upstream

Comments

@jryans
Copy link
Collaborator

jryans commented Jul 31, 2019

Electron 6 recently became the new stable release.

I made a branch to check it out with Riot, but currently it seems to crash immediately on start at least for macOS:

Thread 0:: CrBrowserMain  Dispatch queue: com.apple.main-thread
0   libCGInterfaces.dylib         	0x00007fff48ecf477 Init_CGInterfaces + 7
1   com.apple.vImage              	0x00007fff48ee64db InitCGInterfaces + 539
2   libdispatch.dylib             	0x00007fff78a2d63d _dispatch_client_callout + 8
3   libdispatch.dylib             	0x00007fff78a2ed4b _dispatch_once_callout + 20
4   com.apple.vImage              	0x00007fff48ee62b0 LoadCGInterfaces + 48
5   com.apple.vImage              	0x00007fff48ee59e8 vImageConverter_CreateWithColorSyncCodeFragment + 72
6   com.apple.CoreGraphics        	0x00007fff4cf3c2d3 CGvImageConverterInitializeShared + 516
7   com.apple.CoreGraphics        	0x00007fff4cf3bac7 CGvImageConverterCacheGetRetained + 877
8   com.apple.CoreGraphics        	0x00007fff4cf3b714 CGCMSConverterCreateCachedCGvImageConverter + 76
9   com.apple.CoreGraphics        	0x00007fff4cf3b624 convert_using_vImageConverter + 393
10  com.apple.CoreGraphics        	0x00007fff4cf3b472 convert_icc + 46
11  com.apple.CoreGraphics        	0x00007fff4cf3b42f CGCMSConverterConvert + 113
12  com.apple.CoreGraphics        	0x00007fff4cf3b32b CGCMSConverterConvertColorComponents + 598
13  com.apple.CoreGraphics        	0x00007fff4cf39c0a CGColorTransformConvertColorComponents + 573
14  com.apple.CoreGraphics        	0x00007fff4cf492e0 ripc_GetColor + 1596
15  com.apple.CoreGraphics        	0x00007fff4cf48325 ripc_Render + 156
16  com.apple.CoreGraphics        	0x00007fff4cf453e3 ripc_DrawRects + 354
17  com.apple.CoreGraphics        	0x00007fff4cf451f2 CGContextFillRects + 96
18  com.apple.CoreGraphics        	0x00007fff4cf4518b CGContextFillRect + 105
19  com.apple.coreui              	0x00007fff61217590 -[CUIShapeEffectStack newColorByProcessingColor:] + 470
20  com.apple.coreui              	0x00007fff611ef9e2 CUICoreThemeRenderer::CopyCustomColorCore(__CFString const*, __CFDictionary const*) const + 574
21  com.apple.coreui              	0x00007fff611ef768 CUICopyCustomColorWithOptions + 236
22  com.apple.AppKit              	0x00007fff4a10826c __44-[NSAppearance _copyCustomCGColor:withTint:]_block_invoke + 24
23  com.apple.AppKit              	0x00007fff4a12d773 -[NSCompositeAppearance _callCoreUIWithBlock:options:] + 363
24  com.apple.AppKit              	0x00007fff4a108201 -[NSAppearance _copyCustomCGColor:withTint:] + 221
25  com.apple.AppKit              	0x00007fff4a1080ec -[NSAppearance _customColor:withTint:] + 20
26  com.apple.AppKit              	0x00007fff4a2f0bca -[NSDynamicModifiedColor resolvedColor] + 197
27  com.apple.AppKit              	0x00007fff4a2f07ea -[NSDynamicNamedColor colorUsingColorSpace:] + 30
28  com.apple.AppKit              	0x00007fff4a2f0830 -[NSDynamicNamedColor colorUsingColorSpace:] + 100
29  com.github.Electron.framework 	0x000000010d40b1ad 0x10b632000 + 31297965
30  com.github.Electron.framework 	0x000000010d40aab9 0x10b632000 + 31296185
31  com.github.Electron.framework 	0x000000010d40a729 0x10b632000 + 31295273
32  com.github.Electron.framework 	0x000000010d40a602 0x10b632000 + 31294978
33  com.github.Electron.framework 	0x000000010ce98d73 0x10b632000 + 25587059
34  com.github.Electron.framework 	0x000000010d2eab97 0x10b632000 + 30116759
35  com.github.Electron.framework 	0x000000010ce97ec6 0x10b632000 + 25583302
36  com.github.Electron.framework 	0x000000010ce9aae2 0x10b632000 + 25594594
37  com.github.Electron.framework 	0x000000010ce96496 0x10b632000 + 25576598
38  com.github.Electron.framework 	0x000000010cd6b185 0x10b632000 + 24351109
39  com.github.Electron.framework 	0x000000010cd6ad71 0x10b632000 + 24350065
40  com.github.Electron.framework 	0x000000010f0fd670 0x10b632000 + 61650544
41  com.github.Electron.framework 	0x000000010bff7ab4 0x10b632000 + 10246836
42  com.github.Electron.framework 	0x000000010b635014 AtomMain + 84
43  im.riot.app                   	0x000000010b5fca10 0x10b5fb000 + 6672
44  libdyld.dylib                 	0x00007fff78a7a3d5 start + 1

My branch also upgrades electron-builder, which does mention some signing and sandboxing changes in the release notes. If upgrade only Electron and leave electron-builder as is, we still get a crash with:

Thread 0:: CrBrowserMain  Dispatch queue: com.apple.main-thread
0   libobjc.A.dylib               	0x00007fff772a052e cache_t::reallocate(unsigned int, unsigned int) + 58
1   libobjc.A.dylib               	0x00007fff7729fd0b cache_fill + 195
2   libobjc.A.dylib               	0x00007fff7729fa03 lookUpImpOrForward + 1111
3   libobjc.A.dylib               	0x00007fff7729f114 _objc_msgSend_uncached + 68
4   com.apple.AppKit              	0x00007fff4a1086b9 +[NSColor colorWithColorSpace:components:count:] + 29
5   com.apple.AppKit              	0x00007fff4a186892 +[NSColor colorWithSRGBRed:green:blue:alpha:] + 106
6   com.apple.AppKit              	0x00007fff4a14b93a __36-[NSDynamicSystemColor recacheColor]_block_invoke + 56
7   com.apple.AppKit              	0x00007fff4a14b869 +[NSAppearance _performWithCurrentAppearance:usingBlock:] + 84
8   com.apple.AppKit              	0x00007fff4a14b77a -[NSDynamicSystemColor recacheColor] + 305
9   com.apple.AppKit              	0x00007fff4a14b526 -[NSDynamicSystemColor initWithSelector:tintedWithColor:] + 120
10  com.apple.AppKit              	0x00007fff4a18674c +[NSColor controlAccentBlueColor] + 80
11  com.apple.AppKit              	0x00007fff4a1866f2 _NSColorBaseUserHighlightColor + 104
12  com.apple.AppKit              	0x00007fff4a2dd7d7 +[NSDynamicSystemColor alternateSelectedControlColor] + 28
13  com.apple.AppKit              	0x00007fff4a14b93a __36-[NSDynamicSystemColor recacheColor]_block_invoke + 56
14  com.apple.AppKit              	0x00007fff4a14b869 +[NSAppearance _performWithCurrentAppearance:usingBlock:] + 84
15  com.apple.AppKit              	0x00007fff4a14b77a -[NSDynamicSystemColor recacheColor] + 305
16  com.apple.AppKit              	0x00007fff4a14b526 -[NSDynamicSystemColor initWithSelector:tintedWithColor:] + 120
17  com.apple.AppKit              	0x00007fff4a2dd711 +[NSColor alternateSelectedControlColor] + 80
18  com.github.Electron.framework 	0x000000010aef0ab1 0x109118000 + 31296177
19  com.github.Electron.framework 	0x000000010aef0729 0x109118000 + 31295273
20  com.github.Electron.framework 	0x000000010aef0602 0x109118000 + 31294978
21  com.github.Electron.framework 	0x000000010a97ed73 0x109118000 + 25587059
22  com.github.Electron.framework 	0x000000010add0b97 0x109118000 + 30116759
23  com.github.Electron.framework 	0x000000010a97dec6 0x109118000 + 25583302
24  com.github.Electron.framework 	0x000000010a980ae2 0x109118000 + 25594594
25  com.github.Electron.framework 	0x000000010a97c496 0x109118000 + 25576598
26  com.github.Electron.framework 	0x000000010a851185 0x109118000 + 24351109
27  com.github.Electron.framework 	0x000000010a850d71 0x109118000 + 24350065
28  com.github.Electron.framework 	0x000000010cbe3670 0x109118000 + 61650544
29  com.github.Electron.framework 	0x0000000109addab4 0x109118000 + 10246836
30  com.github.Electron.framework 	0x000000010911b014 AtomMain + 84
31  im.riot.app                   	0x0000000105d7ea10 0x105d7d000 + 6672
32  libdyld.dylib                 	0x00007fff78a7a3d5 start + 1

Seems possibly related to extra helper apps in Electron 6 that need electron-builder changes.
@eli-schwartz
Copy link

On Arch Linux, updating the system /usr/bin/electron binary to electron 6 and using it to run the packaged riot-desktop application works fine.

jryans added a commit that referenced this issue Aug 16, 2019
@jryans
Upgrade electron-builder to 21.2.0
24e59cc 
This is meant to help with:

* macOS packaging for Electron 6 (#10473)
* Linux desktop file should not have quotes (#6421)

It did not help with:

* Linux sandbox for Electron 5 (#10509)

Fixes #6421
Part of #10473
@jryans jryans mentioned this issue Aug 16, 2019
Merged
@jryans jryans self-assigned this Aug 20, 2019
@jryans
Copy link
Collaborator Author

jryans commented Aug 20, 2019

Fixed by #10579

@jryans jryans closed this as completed Aug 20, 2019
su-ex added a commit to SchildiChat/element-web that referenced this issue Apr 25, 2023
@su-ex
Merge tag 'v1.11.30' into sc
1968a49 
* Fixes for [CVE-2023-30609](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE-2023-30609) / GHSA-xv83-x443-7rmw
* Pick sensible default option for phone country dropdown ([\element-hq#10627](matrix-org/matrix-react-sdk#10627)). Fixes element-hq#3528.
* Relate field validation tooltip via aria-describedby ([\element-hq#10522](matrix-org/matrix-react-sdk#10522)). Fixes element-hq#24963.
* Handle more completion types in rte autocomplete ([\element-hq#10560](matrix-org/matrix-react-sdk#10560)). Contributed by @alunturner.
* Show a tile for an unloaded predecessor room if it has via_servers ([\element-hq#10483](matrix-org/matrix-react-sdk#10483)). Contributed by @andybalaam.
* Exclude message timestamps from aria live region ([\element-hq#10584](matrix-org/matrix-react-sdk#10584)). Fixes element-hq#5696.
* Make composer format bar an aria toolbar ([\element-hq#10583](matrix-org/matrix-react-sdk#10583)). Fixes element-hq#11283.
* Improve accessibility of font slider ([\element-hq#10473](matrix-org/matrix-react-sdk#10473)). Fixes element-hq#20168 and element-hq#24962.
* fix file size display from kB to KB ([\element-hq#10561](matrix-org/matrix-react-sdk#10561)). Fixes element-hq#24866. Contributed by @NSV1991.
* Handle /me in rte ([\element-hq#10558](matrix-org/matrix-react-sdk#10558)). Contributed by @alunturner.
* bind html with switch for manage extension setting option ([\element-hq#10553](matrix-org/matrix-react-sdk#10553)). Contributed by @NSV1991.
* Handle command completions in RTE ([\element-hq#10521](matrix-org/matrix-react-sdk#10521)). Contributed by @alunturner.
* Add room and user avatars to rte ([\element-hq#10497](matrix-org/matrix-react-sdk#10497)). Contributed by @alunturner.
* Support for MSC3882 revision 1 ([\element-hq#10443](matrix-org/matrix-react-sdk#10443)). Contributed by @hughns.
* Check profiles before starting a DM ([\element-hq#10472](matrix-org/matrix-react-sdk#10472)). Fixes element-hq#24830.
* Quick settings: Change the copy / labels on the options ([\element-hq#10427](matrix-org/matrix-react-sdk#10427)). Fixes element-hq#24522. Contributed by @justjanne.
* Update rte autocomplete styling ([\element-hq#10503](matrix-org/matrix-react-sdk#10503)). Contributed by @alunturner.
* Fix create subspace dialog not working ([\element-hq#10652](matrix-org/matrix-react-sdk#10652)). Fixes element-hq#24882
* Fix multiple accessibility defects identified by AXE ([\element-hq#10606](matrix-org/matrix-react-sdk#10606)).
* Fix view source from edit history dialog always showing latest event ([\element-hq#10626](matrix-org/matrix-react-sdk#10626)). Fixes element-hq#21859.
* element-hq#21451 Fix WebGL disabled error message ([\element-hq#10589](matrix-org/matrix-react-sdk#10589)). Contributed by @rashmitpankhania.
* Properly translate errors in `AddThreepid.ts` so they show up translated to the user but not in our logs ([\element-hq#10432](matrix-org/matrix-react-sdk#10432)). Contributed by @MadLittleMods.
* Fix overflow on auth pages ([\element-hq#10605](matrix-org/matrix-react-sdk#10605)). Fixes element-hq#19548.
* Fix incorrect avatar background colour when using a custom theme ([\#10598](matrix-org/matrix-react-sdk#10598)). Contributed by @jdauphant.
* Remove dependency on `org.matrix.e2e_cross_signing` unstable feature ([\element-hq#10593](matrix-org/matrix-react-sdk#10593)).
* Update setting description to match reality ([\element-hq#10600](matrix-org/matrix-react-sdk#10600)). Fixes element-hq#25106.
* Fix no identity server in help & about settings ([\element-hq#10563](matrix-org/matrix-react-sdk#10563)). Fixes element-hq#25077.
* Fix: Images no longer reserve their space in the timeline correctly ([\element-hq#10571](matrix-org/matrix-react-sdk#10571)). Fixes element-hq#25082. Contributed by @kerryarchibald.
* Fix issues with inhibited accessible focus outlines ([\element-hq#10579](matrix-org/matrix-react-sdk#10579)). Fixes element-hq#19742.
* Fix read receipts falling from sky ([\element-hq#10576](matrix-org/matrix-react-sdk#10576)). Fixes element-hq#25081.
* Fix avatar text issue in rte ([\element-hq#10559](matrix-org/matrix-react-sdk#10559)). Contributed by @alunturner.
* fix resizer only work with left mouse click ([\element-hq#10546](matrix-org/matrix-react-sdk#10546)). Contributed by @NSV1991.
* Fix send two join requests when joining a room from spotlight search ([\#10534](matrix-org/matrix-react-sdk#10534)). Fixes element-hq#25054.
* Highlight event when any version triggered a highlight ([\element-hq#10502](matrix-org/matrix-react-sdk#10502)). Fixes element-hq#24923 and element-hq#24970. Contributed by @kerryarchibald.
* Fix spacing of headings of integration manager on General settings tab ([\element-hq#10232](matrix-org/matrix-react-sdk#10232)). Fixes element-hq#24085. Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Electron P2 T-Defect T-Task Tasks for the team like planning Z-Upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @eli-schwartz