Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peeking a room over federation without previews allowed spins forever & cannot join #12500

Closed
jryans opened this issue Feb 25, 2020 · 6 comments · Fixed by matrix-org/matrix-react-sdk#4132

Comments

@jryans
Copy link
Collaborator

jryans commented Feb 25, 2020

If I try to peek a room over federation without previews allowed, Riot hangs with a spinner:

2020-02-25 at 02 06

Looking at network traffic, there is an initialSync request that fails with 403 Forbidden:

GET /_matrix/client/r0/rooms/<room_id>/initialSync?limit=20

HTTP/2 403 Forbidden

{
    "errcode":"M_FORBIDDEN",
    "error":"User <mxid> not in room <room_id>, and room previews are disabled"
}
@jryans
Copy link
Collaborator Author

jryans commented Feb 25, 2020

The particular room I tried to join has in room state:

"join_rule": "public",
"guest_access": "can_join",
"history_visibility": "world_readable",

@jryans
Copy link
Collaborator Author

jryans commented Feb 25, 2020

I suppose the fundamental issue is that we don't support peeking over federation today, but hopefully matrix-org/matrix-spec-proposals#2444 will help at a protocol level.

We can still do a lot more here in the client to convey the current error state.

@turt2live
Copy link
Member

turt2live commented Feb 25, 2020

This used to work just fine in Riot, counting it as a regression.

@ara4n
Copy link
Member

ara4n commented Feb 25, 2020

The problem is worse though - not only does the peek never load, it sounds like there's no option to join? So this means that clicking on any room link over federation is currently broken, which is a pretty spectacular regression.

@turt2live turt2live changed the title Peeking a room over federation without previews allowed spins forever Peeking a room over federation without previews allowed spins forever & cannot join Feb 25, 2020
@turt2live
Copy link
Member

Hmm... this seems to be working fine for me:
image

even with the 403.

@turt2live turt2live self-assigned this Feb 25, 2020
@turt2live
Copy link
Member

Caused by matrix-org/synapse#6992 - will fix anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants